Conversation
With Erlang.mk, test nodes inherit from the `ERL_LIBS` environment variable, so setting the code path on the test node command line was unnecessary. However, Rebar does not set this variable. Therefore we need to explicitly add these dependencies to the code path.
This doesn't play nicely with other testsuites that ran previously because we loose their logs and data. While here, move the configuration of the logger and sasl to the testsuite init. There is no need to to it for each test group. Also remove the log handler on teardown, otherwise it keeps a log file open.
This reduces the risk of a test flake, in particular in CI.
…shot` ... instead of checking it once after a sleep. This reduces the risk of a test flake in CI.
... in `delete_*_server_cluster*()`. This should help reduce the risk of a test flake in CI. tests
All of them were related to return values not being matched.
[Why] We have to use an unreleased version of the `setup-beam` action to benefit from a fix when it is used on Windows. Unfortunately, setup-beam still has no release with that fix, despite multiple requests. [How] For now, disable this job for pull requests and pushes to the main branch.
This required the use of Rebar instead of Erlang.mk to avoid any issues with paths in Make.
dc0b5bb to
73f7e45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch:
The modified workflow uses Rebar instead of Erlang.mk because Make and paths on Windows don’t work well. Also, Make is slow on Windows.
Note that the "Check actions update" GitHub Actions had to be disabled temporarily because we need an unreleased version of
setup-beamthat works on Windows.