Fix bug where the persisted last applied could be higher than last wr…#562
Merged
michaelklishin merged 1 commit intomainfrom Nov 6, 2025
Merged
Conversation
…itten. This could happen as some members can apply indexes even if they haven't yet been locally written fully as long as the commit index is higher. In this case it would persist the last applied index even if the entry had not been persisted by the WAL. If the WAL then crashed and the node then restarted the member would fail at recovery as it would try to recover up to a last applied index that does not exist.
michaelklishin
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…itten.
This could happen as some members can apply indexes even if they haven't yet been locally written fully as long as the commit index is higher.
In this case it would persist the last applied index even if the entry had not been persisted by the WAL. If the WAL then crashed and the node then restarted the member would fail at recovery as it would try to recover up to a last applied index that does not exist.