Skip to content

Fixes #560 - fix crash in wal_log_segment_writer when wal_data_dir /= data_dir#561

Merged
kjnilsson merged 1 commit intorabbitmq:mainfrom
mbj4668:mbj/fix-wal-data-dir
Nov 5, 2025
Merged

Fixes #560 - fix crash in wal_log_segment_writer when wal_data_dir /= data_dir#561
kjnilsson merged 1 commit intorabbitmq:mainfrom
mbj4668:mbj/fix-wal-data-dir

Conversation

@mbj4668
Copy link
Copy Markdown
Contributor

@mbj4668 mbj4668 commented Nov 5, 2025

Proposed Changes

Fixes #560. ra_log_segment_writer would crash if wal_data_dir was not the same as data_dir, b/c
it tried to delete a non-existing file.

The fix is to send the full filename of the wal file to ra_log_segment_writer.

Types of Changes

  • Bug fix (non-breaking change which fixes issue Config parameter wal_data_dir leads to crash #560)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance)

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq) (link doesn't work)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

@kjnilsson kjnilsson merged commit d7ff40c into rabbitmq:main Nov 5, 2025
4 checks passed
@kjnilsson
Copy link
Copy Markdown
Contributor

I dont mind this approach - thanks!

@michaelklishin michaelklishin added this to the 2.17.2 milestone Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Config parameter wal_data_dir leads to crash

3 participants