Handle shutdown exits in gen_statem:call/3#388
Merged
michaelklishin merged 1 commit intomainfrom Jul 17, 2023
Merged
Conversation
Contributor
|
I like the shutdown one better. |
Collaborator
Author
|
Yeah that sounds good to me. |
06a4b1f to
3e7e199
Compare
michaelklishin
approved these changes
Jul 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
gen_statem:call/3can fail if the server shuts down before replying to the call, exiting with{shutdown, Location}. We can handle this exit like the other exits in thegen_statem_safe_call/3. I think it makes sense to return{error, noproc}in this case since it's effectively the same as the server not being alive, but I think an{error, shutdown}return could be ok as well.Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creatingthe PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.
CONTRIBUTING.mddocument