fix: close TLS connection on STOMP connect failure

mkuratczyk · mkuratczyk · commit 120d2060bbba · 2026-03-13T00:51:54.000+01:00
When stomp.Connect() fails after a successful tls.Dial(), the underlying
net.Conn was leaked. This fix ensures the TLS connection is properly
closed when the STOMP protocol handshake fails, preventing file
descriptor leaks in both publisher and consumer.
diff --git a/pkg/stomp/consumer.go b/pkg/stomp/consumer.go
@@ -82,6 +82,9 @@ func (c *StompConsumer) Connect() {
 				err = tlsErr
 			} else {
 				conn, err = stomp.Connect(netConn, o...)
+				if err != nil {
+					_ = netConn.Close()
+				}
 			}
 		} else {
 			conn, err = stomp.Dial("tcp", parsedUri.Broker, o...)
diff --git a/pkg/stomp/publisher.go b/pkg/stomp/publisher.go
@@ -75,6 +75,9 @@ func (p *StompPublisher) Connect() {
 				err = tlsErr
 			} else {
 				conn, err = stomp.Connect(netConn, o...)
+				if err != nil {
+					_ = netConn.Close()
+				}
 			}
 		} else {
 			conn, err = stomp.Dial("tcp", parsedUri.Broker, o...)
