Conversation
[Why] Using the Ra counters is still expensive, even though it is more efficient than querying the Ra server directly. [How] Now, we cache the effective machine version when the machine is initialised or when a new version is applied. The value is cached in a persistent term. This fixes a performance bottleneck when under high load.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v0.17.x #349 +/- ##
===========================================
- Coverage 86.34% 86.15% -0.20%
===========================================
Files 22 22
Lines 3450 3460 +10
===========================================
+ Hits 2979 2981 +2
- Misses 471 479 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Using the Ra counters is still expensive, even though it is more efficient than querying the Ra server directly.
How
Now, we cache the effective machine version when the machine is initialised or when a new version is applied. The value is cached in a persistent term.
This fixes a performance bottleneck when under high load.