Conversation
MirahImage
approved these changes
Feb 10, 2026
Member
MirahImage
left a comment
There was a problem hiding this comment.
We should attempt to remember to switch to the new API/cli call once the oldest supported RabbitMQ version has it.
mkuratczyk
approved these changes
Feb 10, 2026
Contributor
mkuratczyk
left a comment
There was a problem hiding this comment.
I thought that the eval approach would be for PoC only, but as long as me move to something better soon, I guess it's fine. Alternatively, we could call the new CLI/API and ignore errors if it doesn't exist so that this feature works only with versions that ship the new CLI/API
fe92590 to
512dbc3
Compare
Member
Author
|
Initially it was a PoC, but this interim change is beneficial and solves a long outstanding edge case with cluster formation. I left a TODO comment to replace the probe with an actual HTTP call when rabbit supports it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #2016
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Summary Of Changes
Local Testing
Added unit and integration test.