Add Apple Silicon architecture for macOS#119
Closed
Shakarang wants to merge 1 commit intora1028:masterfrom
Closed
Conversation
Contributor
|
Valid Archs is not valid settings anymore in XCode 12, does it still work? |
Author
Yes, we are still using this in Xcode 12.3 |
|
I think you need to fix the xcconfig. https://github.com/ra1028/DifferenceKit/blob/master/XCConfigs/DifferenceKit.xcconfig |
4 tasks
Owner
|
Fixed #124 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Apple will release the the architecture Apple Silicon. To make it work with
DifferenceKit, we need to addarm64to the valid architectures of macOS builds.Related Issue
#118
Motivation and Context
It allows us to use DifferenceKit on Apple Silicon Mac.
Impact on Existing Code
Nothing.