Make DiffableDataSourceSnapshot struct#3
Merged
ra1028 merged 1 commit intora1028:masterfrom Sep 2, 2019
kishikawakatsumi:class-to-struct
Merged
Make DiffableDataSourceSnapshot struct#3ra1028 merged 1 commit intora1028:masterfrom kishikawakatsumi:class-to-struct
DiffableDataSourceSnapshot struct#3ra1028 merged 1 commit intora1028:masterfrom
kishikawakatsumi:class-to-struct
Conversation
In the latest Xcode 11 (beta 6), DiffableDataSourceSnapshot class changed to a struct. This PR adopt the API to the latest UIKit's API.
Owner
|
Great catch up @kishikawakatsumi ! |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the latest Xcode 11 (beta 6), DiffableDataSourceSnapshot class changed to a struct.
This PR adopt the API to the latest UIKit's API.
Checklist
Description
Motivation and Context
If we can write
let snapshotas before, we can't copy and paste as it is when we migrate to the iOS 13 standard API in the future. Because oflet snapshotalmost causes compilation error on in Cocoa's API.Impact on Existing Code
In most cases
let snapshotis now a compilation error. Users should rewrite it tovar snapshot.