Fix handling of unused alignment#132
Merged
r1chardj0n3s merged 2 commits intor1chardj0n3s:masterfrom Jun 4, 2021
Merged
Conversation
…r1chardj0n3s#112, but which broke more verbose use cases. The proper solution to r1chardj0n3s#112 should have been to instructing the user to use the '{:^S},{^:S}' pattern instead, because in some cases format() is not really reversible so you ought to be more verbose in your format. This resolves r1chardj0n3s#118.
r1chardj0n3s
requested changes
Mar 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts a change introduced in 55467d2 (1.17) in order to resolve #112, but which broke more verbose use cases.
The proper solution to #112 should have been to instructing the user to use the '{:^S},{^:S}' pattern instead, because in some cases format() is not really reversible so you ought to be more verbose in your format.
This resolves #118.