Skip to content

Conversation

@moliholy
Copy link
Collaborator

Closes #743

This PR maps installation errors so that instructions on how to fix lack of permission errors.

Essentially users have ro run sudo $(which pop) install.

Copy link
Collaborator

@Daanvdplas Daanvdplas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@moliholy moliholy self-assigned this Nov 14, 2025
@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

❌ Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.29%. Comparing base (cf39bd3) to head (f31feb8).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/pop-cli/src/commands/install/mod.rs 0.00% 21 Missing ⚠️
@@            Coverage Diff             @@
##             main     #748      +/-   ##
==========================================
- Coverage   76.33%   76.29%   -0.04%     
==========================================
  Files         115      115              
  Lines       25990    26003      +13     
  Branches    25990    26003      +13     
==========================================
  Hits        19840    19840              
- Misses       4010     4023      +13     
  Partials     2140     2140              
Files with missing lines Coverage Δ
crates/pop-cli/src/commands/install/mod.rs 47.07% <0.00%> (-1.55%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@moliholy moliholy merged commit f63998d into main Nov 14, 2025
24 checks passed
@moliholy moliholy deleted the fix/install-sudo-error branch November 14, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pop install error

3 participants