-
Notifications
You must be signed in to change notification settings - Fork 40
feat: remove --dry-run from pop call
#744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
--dry-run from pop call
|
Nice one! |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #744 +/- ##
==========================================
+ Coverage 76.27% 76.33% +0.05%
==========================================
Files 115 115
Lines 26016 25990 -26
Branches 26016 25990 -26
==========================================
- Hits 19845 19840 -5
+ Misses 4029 4010 -19
+ Partials 2142 2140 -2
🚀 New features to boost your workflow:
|
|
The issue linked also added: For pop up contract we also have this flag, could we also make it the default there and remove the flag as well, and adding the --execute flag Would be good to have consistency between |
That's a breaking change. Also, the word execute is perfectly aligned to the context of a call, but not that much to the context of deployment. Still, not terribly misaligned either, and it makes sense to keep consistency between both commands. |
AlexD10S
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closes #737
This PR removes the
--dry-runflag frompop call. Now all calls are firstly dry-run regardless of the user specifying the weight or not, and regardless of being actually executed or not.