Skip to content

Conversation

@moliholy
Copy link
Collaborator

@moliholy moliholy commented Nov 13, 2025

Closes #737

This PR removes the --dry-run flag from pop call. Now all calls are firstly dry-run regardless of the user specifying the weight or not, and regardless of being actually executed or not.

@moliholy moliholy changed the title feat: remove --dry-run from pop call feat: remove --dry-run from pop call Nov 13, 2025
@al3mart
Copy link
Member

al3mart commented Nov 13, 2025

Nice one!

@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

❌ Patch coverage is 2.94118% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.33%. Comparing base (0abc898) to head (8a2e26f).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/pop-cli/src/commands/up/contract.rs 7.14% 13 Missing ⚠️
crates/pop-cli/src/commands/call/contract.rs 0.00% 11 Missing ⚠️
crates/pop-contracts/src/call.rs 0.00% 9 Missing ⚠️
@@            Coverage Diff             @@
##             main     #744      +/-   ##
==========================================
+ Coverage   76.27%   76.33%   +0.05%     
==========================================
  Files         115      115              
  Lines       26016    25990      -26     
  Branches    26016    25990      -26     
==========================================
- Hits        19845    19840       -5     
+ Misses       4029     4010      -19     
+ Partials     2142     2140       -2     
Files with missing lines Coverage Δ
crates/pop-cli/src/commands/up/mod.rs 70.40% <ø> (ø)
crates/pop-contracts/src/call.rs 9.34% <0.00%> (+0.41%) ⬆️
crates/pop-cli/src/commands/call/contract.rs 73.14% <0.00%> (+1.33%) ⬆️
crates/pop-cli/src/commands/up/contract.rs 19.85% <7.14%> (-0.10%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Daanvdplas
Copy link
Collaborator

The issue linked also added: For pop up contract we also have this flag, could we also make it the default there and remove the flag as well, and adding the --execute flag

Would be good to have consistency between up and call contracts

@moliholy
Copy link
Collaborator Author

The issue linked also added: For pop up contract we also have this flag, could we also make it the default there and remove the flag as well, and adding the --execute flag

That's a breaking change. Also, the word execute is perfectly aligned to the context of a call, but not that much to the context of deployment. Still, not terribly misaligned either, and it makes sense to keep consistency between both commands.

@moliholy moliholy self-assigned this Nov 14, 2025
Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@moliholy moliholy merged commit cf39bd3 into main Nov 14, 2025
19 checks passed
@moliholy moliholy deleted the feat/remove-dry-run-from-call branch November 14, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pop call contract --dryrun flag unnecessary

5 participants