Skip to content

fix: improve message #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
moliholy merged 1 commit into from
Nov 13, 2025
Merged

fix: improve message #741

moliholy merged 1 commit into from
Nov 13, 2025

Conversation

@moliholy
Copy link
Collaborator

@moliholy moliholy commented Nov 13, 2025

Closes #717

@moliholy moliholy self-assigned this Nov 13, 2025
@codecov
Copy link

codecov bot commented Nov 13, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 76.29%. Comparing base (17fe387) to head (0ea2f9d).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/pop-cli/src/commands/new/chain.rs 0.00% 1 Missing ⚠️ 
@@           Coverage Diff           @@
##             main     #741   +/-   ##
=======================================
  Coverage   76.29%   76.29%           
=======================================
  Files         115      115           
  Lines       25908    25908           
  Branches    25908    25908           
=======================================
  Hits        19766    19766           
  Misses       4015     4015           
  Partials     2127     2127
Files with missing lines Coverage Δ
crates/pop-cli/src/commands/new/chain.rs 47.54% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AlexD10S AlexD10S mentioned this pull request Nov 13, 2025
Closed
@moliholy moliholy merged commit 39ece66 into main Nov 13, 2025
19 checks passed
@moliholy moliholy deleted the fix/pop-up-message branch November 13, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexD10S AlexD10S AlexD10S approved these changes

@al3mart al3mart Awaiting requested review from al3mart

@Daanvdplas Daanvdplas Awaiting requested review from Daanvdplas

Assignees

@moliholy moliholy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Invalid option -f for pop up chain

3 participants

@moliholy @AlexD10S