Skip to content

feat: add command to upgrade polkadot-sdk version #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
moliholy merged 3 commits into from
Nov 12, 2025
Merged

feat: add command to upgrade polkadot-sdk version #728

moliholy merged 3 commits into from
Nov 12, 2025

Conversation

@moliholy
Copy link
Collaborator

@moliholy moliholy commented Nov 11, 2025 •
edited
Loading

Closes #691.

This PR adds a new upgrade command to upgrade to a new polkadot-sdk version.

Screenshot 2025-11-12 at 00 31 17
Screenshot 2025-11-12 at 00 34 23

@moliholy moliholy self-assigned this Nov 11, 2025
@codecov
Copy link

codecov bot commented Nov 11, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 75.53957% with 34 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.49%. Comparing base (db9a6d5) to head (4dad0f5).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/pop-cli/src/commands/upgrade.rs 77.77% 5 Missing and 25 partials ⚠️
crates/pop-cli/src/commands/mod.rs 0.00% 4 Missing ⚠️ 
@@           Coverage Diff            @@
##             main     #728    +/-   ##
========================================
  Coverage   76.49%   76.49%            
========================================
  Files         114      115     +1     
  Lines       25614    25753   +139     
  Branches    25614    25753   +139     
========================================
+ Hits        19593    19700   +107     
- Misses       3930     3937     +7     
- Partials     2091     2116    +25
Files with missing lines Coverage Δ
crates/pop-cli/src/commands/mod.rs 67.32% <0.00%> (-1.37%) ⬇️
crates/pop-cli/src/commands/upgrade.rs 77.77% <77.77%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@moliholy moliholy marked this pull request as ready for review November 11, 2025 13:15
@moliholy moliholy requested review from AlexD10S and al3mart November 11, 2025 13:15
@moliholy moliholy changed the title feat: upgrade polkadot-sdk version feat: add command to upgrade polkadot-sdk version Nov 11, 2025
@moliholy moliholy force-pushed the feat/upgrade-sdk branch 2 times, most recently from ee3fd3d to d91a6d3 Compare November 11, 2025 23:34
al3mart
al3mart approved these changes Nov 12, 2025
View reviewed changes
Copy link
Member

@al3mart al3mart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! 🔥

As usual the list of options to choose from is huge and buries the interface, but luckly filter by text saves the day!

@moliholy moliholy merged commit 9e021fb into main Nov 12, 2025
24 checks passed
@moliholy moliholy deleted the feat/upgrade-sdk branch November 12, 2025 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@al3mart al3mart al3mart approved these changes

@AlexD10S AlexD10S Awaiting requested review from AlexD10S

Assignees

@moliholy moliholy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: Allow pop to update dependencies on demand

3 participants

@moliholy @al3mart