fix: release binary build doesn't generate all binaries #605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2749678 to
aadfdb0
Compare
moliholy
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #600
We found an issue in the CI when generating the binaries:
Basically was only able to publish one of the binaries due to a conflict with the naming: https://github.com/r0gue-io/pop-cli/releases/tag/v0.8.1
This is a known issue in the GitHub Action
actions/upload-artifact@v4actions/upload-artifact#480. The suggested workaround actions/upload-artifact#480 (comment) is to add an index to the artifact name using${{ strategy.job-index }}I tested this fix in my fork, and the binaries were successfully generated: