Skip to content

Conversation

@evilrobot-01
Copy link
Contributor

The polkavm contract jobs are currently running all tests in the project rather than only those which actually have the specified features. That is, parachain jobs are being run in parallel unnecessarily.

This PR simply constrains these jobs to only run over the pop-cli and pop-contracts crates where these features exist.

@codecov
Copy link

codecov bot commented May 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.68%. Comparing base (343cd42) to head (a5a0093).
Report is 3 commits behind head on main.

@@            Coverage Diff             @@
##             main     #540      +/-   ##
==========================================
- Coverage   78.68%   78.68%   -0.01%     
==========================================
  Files         101      101              
  Lines       23926    23926              
  Branches    23926    23926              
==========================================
- Hits        18827    18826       -1     
- Misses       2885     2886       +1     
  Partials     2214     2214              

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Base automatically changed from frank/fix-benchmarking-test to main May 19, 2025 07:47
@evilrobot-01 evilrobot-01 force-pushed the frank/ci-optimise-pvm-jobs branch from eedcd3d to a5a0093 Compare May 19, 2025 08:06
Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes a lot of sense, thanks for taking care of it!

@evilrobot-01 evilrobot-01 merged commit 30763a9 into main May 19, 2025
50 of 52 checks passed
@evilrobot-01 evilrobot-01 deleted the frank/ci-optimise-pvm-jobs branch May 19, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants