fix: template fetching for ink! v5 contracts by pointing to the correct branch #537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #537 +/- ##
==========================================
- Coverage 78.69% 78.68% -0.01%
==========================================
Files 101 101
Lines 23925 23927 +2
Branches 23925 23927 +2
==========================================
Hits 18827 18827
- Misses 2885 2886 +1
- Partials 2213 2214 +1
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
AlexD10S
commented
May 13, 2025
c64d266 to
22601fe
Compare
Daanvdplas
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug reported in the ink! Telegram group, where ink! v5 templates were not loading correctly due to the code fetching from the wrong branch. It was basically generating the template from ink! v6 branch instead of the ink! v5.
The fix updates the logic to fetch templates from the correct branch for ink! v5.
Additionally, a test has been added to ensure this issue doesn’t happen again by validating the correct version after creating a contract.
This PR also bumps the version to
0.8.1to publish the release with the fix.