Skip to content

feat: revive compatibility #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AlexD10S wants to merge 12 commits into from
Closed

feat: revive compatibility #493

AlexD10S wants to merge 12 commits into from

Conversation

@AlexD10S
Copy link
Collaborator

@AlexD10S AlexD10S commented Mar 26, 2025

No description provided.

@AlexD10S AlexD10S marked this pull request as ready for review March 26, 2025 21:08
@AlexD10S AlexD10S marked this pull request as draft March 26, 2025 21:08
@AlexD10S AlexD10S force-pushed the feat/revive-compatibility branch from 0bb00db to dbd4af0 Compare March 26, 2025 22:37
@AlexD10S AlexD10S force-pushed the feat/revive-compatibility branch from dbd4af0 to 24774c0 Compare March 27, 2025 08:56
@codecov
Copy link

codecov bot commented Mar 28, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 57.24638% with 118 lines in your changes missing coverage. Please review.

Project coverage is 76.34%. Comparing base (b6e228a) to head (adc7780).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/pop-cli/src/commands/up/contract.rs 5.55% 26 Missing and 8 partials ⚠️
crates/pop-contracts/src/up.rs 54.16% 25 Missing and 8 partials ⚠️
crates/pop-contracts/src/utils/map_account.rs 70.90% 0 Missing and 16 partials ⚠️
crates/pop-cli/src/commands/call/contract.rs 72.50% 9 Missing and 2 partials ⚠️
crates/pop-contracts/src/call.rs 55.55% 3 Missing and 5 partials ⚠️
crates/pop-common/src/account_id.rs 54.54% 4 Missing and 1 partial ⚠️
crates/pop-cli/src/common/contracts.rs 80.95% 2 Missing and 2 partials ⚠️
crates/pop-common/src/git.rs 50.00% 0 Missing and 3 partials ⚠️
crates/pop-contracts/src/node.rs 57.14% 0 Missing and 3 partials ⚠️
crates/pop-contracts/src/new.rs 0.00% 0 Missing and 1 partial ⚠️ 
@@            Coverage Diff             @@
##             main     #493      +/-   ##
==========================================
- Coverage   76.86%   76.34%   -0.52%     
==========================================
  Files          84       85       +1     
  Lines       19806    19815       +9     
  Branches    19806    19815       +9     
==========================================
- Hits        15223    15128      -95     
- Misses       2600     2689      +89     
- Partials     1983     1998      +15
Files with missing lines Coverage Δ
crates/pop-cli/src/common/binary.rs 68.22% <100.00%> (ø)
crates/pop-common/src/lib.rs 74.50% <ø> (ø)
crates/pop-contracts/src/templates.rs 98.18% <100.00%> (ø)
crates/pop-contracts/src/utils/metadata.rs 91.27% <100.00%> (ø)
crates/pop-contracts/src/utils/mod.rs 81.81% <ø> (ø)
crates/pop-contracts/src/new.rs 84.79% <0.00%> (ø)
crates/pop-common/src/git.rs 76.09% <50.00%> (-0.54%) ⬇️
crates/pop-contracts/src/node.rs 65.78% <57.14%> (-0.25%) ⬇️
crates/pop-cli/src/common/contracts.rs 77.14% <80.95%> (-2.66%) ⬇️
crates/pop-common/src/account_id.rs 82.53% <54.54%> (-5.93%) ⬇️
... and 5 more

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AlexD10S AlexD10S mentioned this pull request Mar 28, 2025
Merged
@AlexD10S
Copy link
Collaborator Author

AlexD10S commented Apr 1, 2025

The logic of this PR has been replaced with #500

@AlexD10S AlexD10S closed this Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AlexD10S