test: improve coverage #391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexD10S
reviewed
Dec 18, 2024
peterwht
requested changes
Dec 18, 2024
Contributor
peterwht
left a comment
There was a problem hiding this comment.
Nice! Just one small sentence change please :)
al3mart
commented
Dec 18, 2024
peterwht
approved these changes
Dec 18, 2024
AlexD10S
requested changes
Dec 18, 2024
Collaborator
AlexD10S
left a comment
There was a problem hiding this comment.
Just one very small point, update the docs in check_contracts_node_and_prompt with the new arguments
AlexD10S
approved these changes
Dec 18, 2024
Collaborator
AlexD10S
left a comment
There was a problem hiding this comment.
Thanks for adding this changes!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves coverage for
terminate_nodecheck_contracts_node_and_promptIn
pop-cli/common/contracts.rsRefactors a few functions so that they receive the Cli as a parameter following the changes in #315 to facilitate testing.