feat(build parachain): generate specification, wasm and genesis state files #219
Conversation
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #219 +/- ##
==========================================
+ Coverage 70.40% 70.81% +0.41%
==========================================
Files 46 47 +1
Lines 7045 7436 +391
Branches 7045 7436 +391
==========================================
+ Hits 4960 5266 +306
- Misses 1258 1283 +25
- Partials 827 887 +60
|
evilrobot-01
left a comment
There was a problem hiding this comment.
Some improvements suggested. I think the use of paths needs special attention,
Expect it will be useful in the future.
# Conflicts: # crates/pop-contracts/src/errors.rs
evilrobot-01
left a comment
There was a problem hiding this comment.
Much cleaner!
I think the only thing to address to conclude this is to remove the need for the toml_edit dependency in common, as the common::manifest module provides a much cleaner way of achieving the same result: resolving the package name. You can probably eliminate the function entirely using the Manifest type which is exported from common.
Also think the build profile should be moved to common.
evilrobot-01
left a comment
There was a problem hiding this comment.
Still a few issues sadly. Should be the last one.
evilrobot-01
left a comment
There was a problem hiding this comment.
LGTM! Thank you for yout patience and persistence in getting this completed. 💪
If the user specifies the
parachain_idwhen building the parachain, the process will include the generation of a chain spec file (Closes #28). Additionally, export the WebAssembly runtime for the parachain, and generate a parachain genesis state (Closes #29).The process for generating the files follows the steps described in the Substrate Tutorial. More explanation in the referenced issues above.
The functions to generate the files are independent of the building process in the
pop_parachaincrate, making it easy to create a separate command for file generation if desired, as discussed in #28.This PR also addresses #188 by displaying the location and name of the built binary.