Skip to content

Reauthentication Flows + Uis#558

Merged
r0adkll merged 5 commits intomainfrom
dh/re-authentication
Jan 18, 2026
Merged

Reauthentication Flows + Uis#558
r0adkll merged 5 commits intomainfrom
dh/re-authentication

Conversation

@r0adkll
Copy link
Owner

@r0adkll r0adkll commented Jan 18, 2026

This update will re-direct the user to reauthenticate if they're refresh tokens ever expire. Resolves #527

Fixes #530 where SearchBar steals input focus when editing bookmarks

Fixes bug where Home feed displays empty state with multiple libraries/accounts

@r0adkll r0adkll enabled auto-merge (squash) January 18, 2026 22:39
@github-actions
Copy link

github-actions bot commented Jan 18, 2026 •
edited
Loading

Warnings
⚠️

Any changes to library code should be reflected in the Changelog.

Please consider adding a note there and adhere to the Changelog Guidelines.
⚠️ Big PR, try to keep changes smaller if you can
⚠️

Ignoring DB schema changes due to ignore-db-change label
Messages
📖 This PR has been checked by Danger

Generated by 🚫 Danger Kotlin against 3098230

@r0adkll r0adkll added the ignore-db-change Used to tell Danger to ignore .sq changes as they only pertain to queries and not schema changes. label Jan 18, 2026
@Rotom-Bot
Copy link
Collaborator

Rotom-Bot commented Jan 18, 2026

Code Coverage

File Coverage [0.19%] ❌
app/android/src/main/java/app/campfire/android/MainActivity.kt 0.00% ❌
app/android/src/main/java/app/campfire/android/toast/AndroidToast.kt 0.00% ❌
app/common/src/commonMain/kotlin/app/campfire/common/di/UserComponent.kt 0.00% ❌
app/common/src/commonMain/kotlin/app/campfire/common/root/RootUi.kt 0.00% ❌
app/common/src/commonMain/kotlin/app/campfire/common/root/UserComponentContent.kt 0.00% ❌
common/compose/src/commonMain/kotlin/app/campfire/common/compose/toast/Toast.kt 0.00% ❌
common/compose/src/commonMain/kotlin/app/campfire/common/compose/widgets/EmptyState.kt 0.00% ❌
core/src/commonMain/kotlin/app/campfire/core/session/UserSession.kt 27.27% ❌
core/src/commonMain/kotlin/app/campfire/core/toast/GlobalToaster.kt 0.00% ❌
core/src/commonMain/kotlin/app/campfire/core/toast/Toast.kt 0.00% ❌
data/account/impl/src/commonMain/kotlin/app/campfire/account/DefaultAccountManager.kt 0.00% ❌
data/account/impl/src/commonMain/kotlin/app/campfire/account/session/UserSessionRestorer.kt 0.00% ❌
data/account/impl/src/commonMain/kotlin/app/campfire/account/storage/SecureTokenStorage.kt 0.00% ❌
data/account/ui/src/commonMain/kotlin/app/campfire/account/ui/picker/AccountPickerBottomSheet.kt 0.00% ❌
data/account/ui/src/commonMain/kotlin/app/campfire/account/ui/picker/AccountPickerPresenter.kt 0.00% ❌
data/account/ui/src/commonMain/kotlin/app/campfire/account/ui/picker/AccountPickerUiState.kt 0.00% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/models/User.kt 0.00% ❌
data/network/impl/src/commonMain/kotlin/app/campfire/network/KtorAudioBookShelfApi.kt 0.00% ❌
data/network/impl/src/commonMain/kotlin/app/campfire/network/KtorAuthAudioBookShelfApi.kt 0.00% ❌
data/network/impl/src/commonMain/kotlin/app/campfire/network/tokens.kt 0.00% ❌
features/auth/api/src/commonMain/kotlin/app/campfire/auth/api/AuthRepository.kt 0.00% ❌
features/auth/impl/src/commonMain/kotlin/app/campfire/auth/DefaultAuthRepository.kt 0.00% ❌
features/auth/impl/src/commonMain/kotlin/app/campfire/auth/local/ExistingUserStorageStrategy.kt 0.00% ❌
features/auth/impl/src/commonMain/kotlin/app/campfire/auth/local/NewUserStorageStrategy.kt 0.00% ❌
features/auth/ui/src/commonMain/kotlin/app/campfire/auth/ui/login/LoginPresenter.kt 0.00% ❌
features/auth/ui/src/commonMain/kotlin/app/campfire/auth/ui/login/LoginUi.kt 0.00% ❌
features/auth/ui/src/commonMain/kotlin/app/campfire/auth/ui/login/composables/ServerCard.kt 0.00% ❌
features/auth/ui/src/commonMain/kotlin/app/campfire/auth/ui/welcome/WelcomePresenter.kt 0.00% ❌
features/home/impl/src/commonMain/kotlin/app/campfire/home/mapping/ShelfMapping.kt 0.00% ❌
features/home/impl/src/commonMain/kotlin/app/campfire/home/store/home/HomeSourceOfTruthFactory.kt 0.00% ❌
features/search/ui/src/commonMain/kotlin/app/campfire/search/ui/CampfireSearchComponent.kt 0.00% ❌
features/search/ui/src/commonMain/kotlin/app/campfire/search/ui/composables/SearchResultContent.kt 0.00% ❌
features/sessions/ui/src/commonMain/kotlin/app/campfire/sessions/ui/PlaybackBar.kt 0.00% ❌
features/sessions/ui/src/commonMain/kotlin/app/campfire/sessions/ui/sheets/bookmarks/BookmarksBottomSheet.kt 0.00% ❌
features/settings/ui/src/commonMain/kotlin/app/campfire/ui/settings/SettingsPresenter.kt 0.00% ❌
features/settings/ui/src/commonMain/kotlin/app/campfire/ui/settings/SettingsUiState.kt 0.00% ❌
features/settings/ui/src/commonMain/kotlin/app/campfire/ui/settings/panes/AboutPane.kt 0.00% ❌
features/settings/ui/src/commonMain/kotlin/app/campfire/ui/settings/panes/DeveloperPane.kt 0.00% ❌
features/user/impl/src/commonMain/kotlin/app/campfire/user/bookmarks/StoreBookmarkRepository.kt 0.00% ❌
ui/appbar/src/commonMain/kotlin/app/campfire/ui/appbar/CampfireSearchAppBar.kt 0.00% ❌
Total Project Coverage 6.40% ❌

@github-actions
Copy link

github-actions bot commented Jan 18, 2026

Android APK @ 3e8dab3

@r0adkll r0adkll merged commit 6643fe7 into main Jan 18, 2026
11 of 12 checks passed
@r0adkll r0adkll deleted the dh/re-authentication branch January 18, 2026 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ignore-db-change Used to tell Danger to ignore .sq changes as they only pertain to queries and not schema changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Search view pops up when trying to edit bookmarks Handle case where account can no-longer auth due to expired refresh token

2 participants

@r0adkll @Rotom-Bot