Skip to content

Fix how we sync and persist the home feed#516

Merged
r0adkll merged 6 commits intomainfrom
dh/fix-home-feed
Dec 16, 2025
Merged

Fix how we sync and persist the home feed#516
r0adkll merged 6 commits intomainfrom
dh/fix-home-feed

Conversation

@r0adkll
Copy link
Owner

@r0adkll r0adkll commented Dec 16, 2025 •
edited
Loading

The current home feed caching layer is a bit busted and naive where we don't properly sync each shelf or its contents often leading to bugs, invalid ordering, and remnant sections.

Fixes #469

@r0adkll
Re-wrote how we sync and update the local database for the home shelf…
8409874 
… and series to more accurately reflect the home feed response from the server
@r0adkll
Fixing migration and removing log line
b7c5085
@r0adkll
Adding theme db schema version
e220ce0 
Remove add to collection action when non-admin
@github-actions
Copy link

github-actions bot commented Dec 16, 2025 •
edited
Loading

Messages
📖 This PR has been checked by Danger
📖

ℹ️ Migrating Database from 2 to 3

Generated by 🚫 Danger Kotlin against 97b3b0c

@github-actions
Copy link

github-actions bot commented Dec 16, 2025 •
edited
Loading

Android APK @ 0f3aa29

@r0adkll r0adkll enabled auto-merge (squash) December 16, 2025 02:44
@Rotom-Bot
Copy link
Collaborator

Rotom-Bot commented Dec 16, 2025

Code Coverage

File Coverage [46.25%] ❌
core/src/commonMain/kotlin/app/campfire/core/session/UserSession.kt 31.58% ❌
data/db/core/src/commonMain/kotlin/app/campfire/db/DatabaseFactory.kt 95.56% ✅
data/db/mapping/src/commonMain/kotlin/app/campfire/data/mapping/SeriesMapping.kt 36.36% ❌
features/home/impl/src/commonMain/kotlin/app/campfire/home/StoreHomeRepository.kt 0.00% ❌
features/home/impl/src/commonMain/kotlin/app/campfire/home/mapping/ShelfMapping.kt 0.00% ❌
features/home/impl/src/commonMain/kotlin/app/campfire/home/store/home/HomeSourceOfTruthFactory.kt 0.00% ❌
features/home/impl/src/commonMain/kotlin/app/campfire/home/store/home/HomeStore.kt 0.00% ❌
features/home/impl/src/commonMain/kotlin/app/campfire/home/store/shelf/ShelfSourceOfTruthFactory.kt 0.00% ❌
features/libraries/ui/src/commonMain/kotlin/app/campfire/libraries/ui/detail/LibraryItemPresenter.kt 87.50% ✅
features/libraries/ui/src/commonMain/kotlin/app/campfire/libraries/ui/detail/LibraryItemUi.kt 48.59% ❌
features/libraries/ui/src/commonMain/kotlin/app/campfire/libraries/ui/detail/LibraryItemUiState.kt 88.46% ✅
features/search/impl/src/commonMain/kotlin/app/campfire/search/store/SearchSourceOfTruthFactory.kt 0.00% ❌
features/series/impl/src/commonMain/kotlin/app/campfire/series/StoreSeriesRepository.kt 38.82% ❌
features/series/impl/src/commonMain/kotlin/app/campfire/series/store/SeriesFetcherFactory.kt 100.00% ✅
features/series/impl/src/commonMain/kotlin/app/campfire/series/store/SeriesSourceOfTruthFactory.kt 59.52% ❌
features/series/impl/src/commonMain/kotlin/app/campfire/series/store/SeriesStore.kt 56.52% ❌
Total Project Coverage 6.56% ❌

@r0adkll r0adkll merged commit 4f1844a into main Dec 16, 2025
6 checks passed
@r0adkll r0adkll deleted the dh/fix-home-feed branch December 16, 2025 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Home Feed + Persistance is still busted

2 participants

@r0adkll @Rotom-Bot