Skip to content

Fixing models where duration is null.#506

Merged
r0adkll merged 3 commits intomainfrom
dh/fix-null-duration-mediaProgress
Dec 14, 2025
Merged

Fixing models where duration is null.#506
r0adkll merged 3 commits intomainfrom
dh/fix-null-duration-mediaProgress

Conversation

@r0adkll
Copy link
Owner

@r0adkll r0adkll commented Dec 13, 2025

There are crash reports where users are crashing after logging in due to null duration value in their mediaProgress on the user object

@github-actions
Copy link

github-actions bot commented Dec 13, 2025 •
edited
Loading

Android APK @ d792289

@r0adkll r0adkll added the ignore-db-change Used to tell Danger to ignore .sq changes as they only pertain to queries and not schema changes. label Dec 13, 2025
@github-actions
Copy link

github-actions bot commented Dec 13, 2025

Warnings
⚠️

Ignoring DB schema changes due to ignore-db-change label
Messages
📖 This PR has been checked by Danger

Generated by 🚫 Danger Kotlin against ac8330d

@Rotom-Bot
Copy link
Collaborator

Rotom-Bot commented Dec 13, 2025

Code Coverage

File Coverage [72.04%] ❌
core/src/commonMain/kotlin/app/campfire/core/model/MediaProgress.kt 100.00% ✅
data/db/core/src/commonMain/kotlin/app/campfire/db/DatabaseFactory.kt 95.45% ✅
data/db/mapping/src/commonMain/kotlin/app/campfire/data/mapping/MediaProgressMapping.kt 0.00% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/models/MediaProgress.kt 0.00% ❌
features/libraries/ui/src/commonMain/kotlin/app/campfire/libraries/ui/detail/LibraryItemPresenter.kt 94.25% ✅
features/libraries/ui/src/commonMain/kotlin/app/campfire/libraries/ui/detail/LibraryItemUi.kt 57.43% ❌
features/libraries/ui/src/commonMain/kotlin/app/campfire/libraries/ui/detail/composables/MediaProgressBar.kt 98.28% ✅
features/libraries/ui/src/commonMain/kotlin/app/campfire/libraries/ui/detail/composables/slots/ProgressSlot.kt 100.00% ✅
Total Project Coverage 6.59% ❌

@r0adkll r0adkll merged commit 4d1ae16 into main Dec 14, 2025
11 of 12 checks passed
@r0adkll r0adkll deleted the dh/fix-null-duration-mediaProgress branch December 14, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ignore-db-change Used to tell Danger to ignore .sq changes as they only pertain to queries and not schema changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@r0adkll @Rotom-Bot