Skip to content

Fix series association in the item detail screen#448

Merged
r0adkll merged 5 commits intomainfrom
dh/library-item-series-fix
Nov 15, 2025
Merged

Fix series association in the item detail screen#448
r0adkll merged 5 commits intomainfrom
dh/library-item-series-fix

Conversation

@r0adkll
Copy link
Owner

@r0adkll r0adkll commented Nov 13, 2025

Resolves #440
and maybe #439

@github-actions
Copy link

github-actions bot commented Nov 13, 2025 •
edited
Loading

Warnings
⚠️ Big PR, try to keep changes smaller if you can
⚠️

Ignoring DB schema changes due to ignore-db-change label
Messages
📖 This PR has been checked by Danger

Generated by 🚫 Danger Kotlin against 37fdce3

@Rotom-Bot
Copy link
Collaborator

Rotom-Bot commented Nov 13, 2025 •
edited
Loading

Code Coverage

File Coverage [7.54%] ❌
common/compose/src/commonMain/kotlin/app/campfire/common/compose/widgets/ItemCollectionCard.kt 0.00% ❌
core/src/commonMain/kotlin/app/campfire/core/extensions/Result.kt 100.00% ✅
core/src/commonMain/kotlin/app/campfire/core/logging/Heartwood.kt 54.29% ❌
core/src/commonMain/kotlin/app/campfire/core/util/RunIf.kt 0.00% ❌
data/db/core/src/androidMain/kotlin/app/campfire/db/SqlDelightDatabasePlatformComponent.kt 0.00% ❌
data/db/core/src/commonMain/kotlin/app/campfire/db/DatabaseComponent.kt 0.00% ❌
data/db/core/src/commonMain/kotlin/app/campfire/db/DatabaseFactory.kt 95.45% ✅
data/db/core/src/commonMain/kotlin/app/campfire/db/DestructiveMigrationSchema.kt 0.00% ❌
data/db/core/src/commonMain/kotlin/app/campfire/db/SqlAdapters.kt 0.00% ❌
data/db/core/src/jvmMain/kotlin/app/campfire/db/SqlDelightDatabasePlatformComponent.kt 0.00% ❌
data/db/mapping/src/commonMain/kotlin/app/campfire/data/mapping/AudioFileMapping.kt 0.00% ❌
data/db/mapping/src/commonMain/kotlin/app/campfire/data/mapping/AudioTrackMapping.kt 0.00% ❌
data/db/mapping/src/commonMain/kotlin/app/campfire/data/mapping/AuthorMapping.kt 0.00% ❌
data/db/mapping/src/commonMain/kotlin/app/campfire/data/mapping/BookmarkMapping.kt 0.00% ❌
data/db/mapping/src/commonMain/kotlin/app/campfire/data/mapping/ChapterMapping.kt 0.00% ❌
data/db/mapping/src/commonMain/kotlin/app/campfire/data/mapping/CollectionMapping.kt 0.00% ❌
data/db/mapping/src/commonMain/kotlin/app/campfire/data/mapping/FetcherResult.kt 100.00% ✅
data/db/mapping/src/commonMain/kotlin/app/campfire/data/mapping/FilterDataMapping.kt 0.00% ❌
data/db/mapping/src/commonMain/kotlin/app/campfire/data/mapping/LibraryItemMapping.kt 0.00% ❌
data/db/mapping/src/commonMain/kotlin/app/campfire/data/mapping/LibraryMapping.kt 0.00% ❌
data/db/mapping/src/commonMain/kotlin/app/campfire/data/mapping/LibraryStatsMapping.kt 0.00% ❌
data/db/mapping/src/commonMain/kotlin/app/campfire/data/mapping/ListeningStatsMapping.kt 0.00% ❌
data/db/mapping/src/commonMain/kotlin/app/campfire/data/mapping/MediaMapping.kt 0.00% ❌
data/db/mapping/src/commonMain/kotlin/app/campfire/data/mapping/MediaProgressMapping.kt 0.00% ❌
data/db/mapping/src/commonMain/kotlin/app/campfire/data/mapping/MetadataMapping.kt 0.00% ❌
data/db/mapping/src/commonMain/kotlin/app/campfire/data/mapping/PlaybackSessionMapping.kt 0.00% ❌
data/db/mapping/src/commonMain/kotlin/app/campfire/data/mapping/SeriesMapping.kt 35.85% ❌
data/db/mapping/src/commonMain/kotlin/app/campfire/data/mapping/ServerMapping.kt 0.00% ❌
data/db/mapping/src/commonMain/kotlin/app/campfire/data/mapping/UserMapping.kt 0.00% ❌
data/db/mapping/src/commonMain/kotlin/app/campfire/data/mapping/dao/LibraryItemDao.kt 0.00% ❌
data/db/mapping/src/commonMain/kotlin/app/campfire/data/mapping/model/LibraryItemWithMedia.kt 0.00% ❌
data/db/mapping/src/commonMain/kotlin/app/campfire/data/mapping/store/StoreUtils.kt 88.00% ✅
data/network/api/src/commonMain/kotlin/app/campfire/network/ApiException.kt 0.00% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/AudioBookShelfApi.kt 0.00% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/PagedResponse.kt 0.00% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/RequestOrigin.kt 100.00% ✅
data/network/api/src/commonMain/kotlin/app/campfire/network/envelopes/ApiResponse.kt 0.00% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/envelopes/Envelope.kt 100.00% ✅
data/network/api/src/commonMain/kotlin/app/campfire/network/envelopes/LoginEnvelope.kt 0.00% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/envelopes/MediaProgressUpdatePayload.kt 0.00% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/envelopes/SessionSyncEnvelope.kt 0.00% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/models/AudioBookmark.kt 0.00% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/models/AudioFile.kt 0.00% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/models/AudioMetaTags.kt 0.00% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/models/AudioTrack.kt 0.00% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/models/Author.kt 0.00% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/models/AuthorExpanded.kt 0.00% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/models/AuthorSeries.kt 0.00% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/models/BookChapter.kt 0.00% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/models/BookMetadata.kt 10.20% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/models/Collection.kt 0.00% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/models/DeviceInfo.kt 0.00% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/models/EmailSettings.kt 0.00% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/models/EreaderDeviceObject.kt 0.00% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/models/FileMetadata.kt 100.00% ✅
data/network/api/src/commonMain/kotlin/app/campfire/network/models/FilterData.kt 0.00% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/models/Folder.kt 0.00% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/models/Library.kt 0.00% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/models/LibraryFile.kt 0.00% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/models/LibraryItemBase.kt 0.00% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/models/LibraryItemExpanded.kt 0.00% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/models/LibraryItemFilter.kt 0.00% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/models/LibraryItemMinified.kt 0.00% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/models/LibraryItemSequence.kt 0.00% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/models/LibrarySettings.kt 0.00% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/models/LibraryStats.kt 0.00% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/models/ListeningStats.kt 0.00% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/models/Media.kt 0.00% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/models/MediaProgress.kt 0.00% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/models/MediaType.kt 0.00% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/models/NetworkModel.kt 100.00% ✅
data/network/api/src/commonMain/kotlin/app/campfire/network/models/Notification.kt 0.00% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/models/NotificationEvent.kt 0.00% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/models/NotificationEventDefaults.kt 0.00% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/models/NotificationEventName.kt 0.00% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/models/NotificationSettings.kt 0.00% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/models/NotificationType.kt 0.00% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/models/PlaybackSession.kt 0.00% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/models/Podcast.kt 0.00% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/models/PodcastEpisode.kt 0.00% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/models/PodcastMetadata.kt 0.00% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/models/SearchResult.kt 0.00% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/models/Series.kt 100.00% ✅
data/network/api/src/commonMain/kotlin/app/campfire/network/models/SeriesBooks.kt 0.00% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/models/SeriesPersonalized.kt 0.00% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/models/SeriesProgress.kt 0.00% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/models/SeriesWithProgressAndRSS.kt 0.00% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/models/SeriesWithProgressAndRSSOneOf.kt 0.00% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/models/ServerSettings.kt 0.00% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/models/Shelf.kt 0.00% ❌
data/network/api/src/commonMain/kotlin/app/campfire/network/models/User.kt 0.00% ❌
data/network/impl/src/androidMain/kotlin/app/campfire/network/di/ConnectivityModule.android.kt 0.00% ❌
data/network/impl/src/commonMain/kotlin/app/campfire/network/KtorAudioBookShelfApi.kt 0.00% ❌
data/network/impl/src/commonMain/kotlin/app/campfire/network/KtorAuthAudioBookShelfApi.kt 0.00% ❌
data/network/impl/src/commonMain/kotlin/app/campfire/network/di/ConnectivityModule.kt 0.00% ❌
data/network/impl/src/commonMain/kotlin/app/campfire/network/di/HttpClientModule.kt 0.00% ❌
data/network/impl/src/commonMain/kotlin/app/campfire/network/envelopes/AuthorResponse.kt 0.00% ❌
data/network/impl/src/commonMain/kotlin/app/campfire/network/envelopes/CollectionRequests.kt 0.00% ❌
data/network/impl/src/commonMain/kotlin/app/campfire/network/envelopes/CollectionsResponse.kt 0.00% ❌
data/network/impl/src/commonMain/kotlin/app/campfire/network/envelopes/CreateBookmarkRequest.kt 0.00% ❌
data/network/impl/src/commonMain/kotlin/app/campfire/network/envelopes/LibraryResponses.kt 0.00% ❌
data/network/impl/src/commonMain/kotlin/app/campfire/network/envelopes/PingResponse.kt 0.00% ❌
data/network/impl/src/commonMain/kotlin/app/campfire/network/envelopes/SeriesResponse.kt 0.00% ❌
data/network/impl/src/commonMain/kotlin/app/campfire/network/envelopes/SyncSessionRequest.kt 0.00% ❌
data/network/impl/src/jvmMain/kotlin/app/campfire/network/di/ConnectivityModule.jvm.kt 0.00% ❌
features/series/impl/src/commonMain/kotlin/app/campfire/series/StoreSeriesRepository.kt 36.25% ❌
features/series/impl/src/commonMain/kotlin/app/campfire/series/store/SeriesSourceOfTruthFactory.kt 59.52% ❌
features/series/impl/src/commonMain/kotlin/app/campfire/series/store/SeriesStore.kt 50.00% ❌
features/series/ui/src/commonMain/kotlin/app/campfire/series/ui/detail/SeriesDetailPresenter.kt 0.00% ❌
features/series/ui/src/commonMain/kotlin/app/campfire/series/ui/list/SeriesPresenter.kt 0.00% ❌
features/series/ui/src/commonMain/kotlin/app/campfire/series/ui/list/SeriesUi.kt 0.00% ❌
Total Project Coverage 7.20% ❌

@github-actions
Copy link

github-actions bot commented Nov 13, 2025 •
edited
Loading

Android APK @ 9ed548f

@r0adkll r0adkll force-pushed the dh/library-item-series-fix branch from 6e9a39a to 37fdce3 Compare November 15, 2025 01:56
@r0adkll r0adkll enabled auto-merge (squash) November 15, 2025 01:56
@r0adkll r0adkll added the ignore-db-change Used to tell Danger to ignore .sq changes as they only pertain to queries and not schema changes. label Nov 15, 2025
@r0adkll r0adkll merged commit 819daab into main Nov 15, 2025
11 of 12 checks passed
@r0adkll r0adkll deleted the dh/library-item-series-fix branch November 15, 2025 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ignore-db-change Used to tell Danger to ignore .sq changes as they only pertain to queries and not schema changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Series missing in Item Detail

2 participants

@r0adkll @Rotom-Bot