Skip to content

Improve rendering of library item details#447

Merged
r0adkll merged 10 commits intomainfrom
dh/library-item-ui-tweaks-and-tests
Nov 13, 2025
Merged

Improve rendering of library item details#447
r0adkll merged 10 commits intomainfrom
dh/library-item-ui-tweaks-and-tests

Conversation

@r0adkll
Copy link
Owner

@r0adkll r0adkll commented Nov 11, 2025

The previous implementation just stuffed everything into a Column that had a scrollable modifier which is not very performant when a lot of content is added (read: Chapters).

So this breaks it up in to ContentSlots that can feed a LazyColumn for more performant rendering and easier arrangement of content.

@github-actions
Copy link

github-actions bot commented Nov 11, 2025 •
edited
Loading

Warnings
⚠️ Big PR, try to keep changes smaller if you can
Messages
📖 This PR has been checked by Danger

Generated by 🚫 Danger Kotlin against 14312ed

@Rotom-Bot
Copy link
Collaborator

Rotom-Bot commented Nov 11, 2025 •
edited
Loading

Code Coverage

File Coverage [86.34%] ✅
common/compose/src/commonMain/kotlin/app/campfire/common/compose/widgets/CoverImage.kt 47.54% ❌
common/compose/src/commonMain/kotlin/app/campfire/common/compose/widgets/Lists.kt 100.00% ✅
core/src/commonMain/kotlin/app/campfire/core/coroutines/DispatcherProvider.kt 0.00% ❌
core/src/commonMain/kotlin/app/campfire/core/extensions/Int.kt 52.38% ❌
core/src/commonMain/kotlin/app/campfire/core/model/preview/LibraryItemPreview.kt 100.00% ✅
core/src/commonMain/kotlin/app/campfire/core/model/preview/MediaProgressPreview.kt 100.00% ✅
features/libraries/ui/src/commonMain/kotlin/app/campfire/libraries/ui/detail/LibraryItemPresenter.kt 97.96% ✅
features/libraries/ui/src/commonMain/kotlin/app/campfire/libraries/ui/detail/LibraryItemUi.kt 48.46% ❌
features/libraries/ui/src/commonMain/kotlin/app/campfire/libraries/ui/detail/LibraryItemUiState.kt 95.45% ✅
features/libraries/ui/src/commonMain/kotlin/app/campfire/libraries/ui/detail/composables/AuthorNarratorBar.kt 98.28% ✅
features/libraries/ui/src/commonMain/kotlin/app/campfire/libraries/ui/detail/composables/ChipSection.kt 100.00% ✅
features/libraries/ui/src/commonMain/kotlin/app/campfire/libraries/ui/detail/composables/ControlBar.kt 98.90% ✅
features/libraries/ui/src/commonMain/kotlin/app/campfire/libraries/ui/detail/composables/ItemDescription.kt 87.76% ✅
features/libraries/ui/src/commonMain/kotlin/app/campfire/libraries/ui/detail/composables/MediaProgressBar.kt 100.00% ✅
features/libraries/ui/src/commonMain/kotlin/app/campfire/libraries/ui/detail/composables/OfflineStatusCard.kt 97.22% ✅
features/libraries/ui/src/commonMain/kotlin/app/campfire/libraries/ui/detail/composables/slots/ChapterHeaderSlot.kt 96.15% ✅
features/libraries/ui/src/commonMain/kotlin/app/campfire/libraries/ui/detail/composables/slots/ChapterSlot.kt 90.48% ✅
features/libraries/ui/src/commonMain/kotlin/app/campfire/libraries/ui/detail/composables/slots/ChipsSlot.kt 100.00% ✅
features/libraries/ui/src/commonMain/kotlin/app/campfire/libraries/ui/detail/composables/slots/ContentSlot.kt 83.33% ✅
features/libraries/ui/src/commonMain/kotlin/app/campfire/libraries/ui/detail/composables/slots/ControlSlot.kt 52.50% ❌
features/libraries/ui/src/commonMain/kotlin/app/campfire/libraries/ui/detail/composables/slots/CoverImageSlot.kt 100.00% ✅
features/libraries/ui/src/commonMain/kotlin/app/campfire/libraries/ui/detail/composables/slots/OfflineStatusSlot.kt 85.71% ✅
features/libraries/ui/src/commonMain/kotlin/app/campfire/libraries/ui/detail/composables/slots/ProgressSlot.kt 90.00% ✅
features/libraries/ui/src/commonMain/kotlin/app/campfire/libraries/ui/detail/composables/slots/PublishedSlot.kt 100.00% ✅
features/libraries/ui/src/commonMain/kotlin/app/campfire/libraries/ui/detail/composables/slots/SeriesSlot.kt 91.30% ✅
features/libraries/ui/src/commonMain/kotlin/app/campfire/libraries/ui/detail/composables/slots/SpacerSlot.kt 50.00% ❌
features/libraries/ui/src/commonMain/kotlin/app/campfire/libraries/ui/detail/composables/slots/SummarySlot.kt 100.00% ✅
features/libraries/ui/src/commonMain/kotlin/app/campfire/libraries/ui/detail/composables/slots/TitleAndAuthorSlot.kt 94.55% ✅
Total Project Coverage 5.69% ❌

@github-actions
Copy link

github-actions bot commented Nov 11, 2025 •
edited
Loading

Android APK @ f9ec55d

@r0adkll r0adkll enabled auto-merge (squash) November 13, 2025 03:35
@r0adkll r0adkll merged commit 4df9c9a into main Nov 13, 2025
6 checks passed
@r0adkll r0adkll deleted the dh/library-item-ui-tweaks-and-tests branch November 13, 2025 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@r0adkll @Rotom-Bot