Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.61%. Comparing base (8c5e6e8) to head (b10b5c8).
Report is 1 commits behind head on v2-branch.

@@            Coverage Diff             @@
##           v2-branch     #966   +/-   ##
==========================================
  Coverage      84.61%   84.61%           
==========================================
  Files              3        3           
  Lines             13       13           
==========================================
  Hits              11       11           
  Misses             2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CodeQL manual fix, need to replace

let e=A.replace("*","(.*)");

with

let e=A.replace(/[*]/g,"(.*)");

It downloads the correct installer:
https://github.com/r-lib/actions/actions/runs/13069938118/job/36469161170#step:5:17
https://github.com/r-lib/actions/actions/runs/13069938118/job/36469161436#step:5:17

lgtm. Btw to build portable macos binary packages (that run on a system that does nos not have the gfortran toolchain installed) we need to override FLIBS to link to gfortran that is part of the R framework, like so: https://github.com/r-universe-org/actions/tree/v5/macos-prep/gfortran-14

But I don't think that matters for just checking the package locally.

Btw to build portable macos binary packages (that run on a system that does nos not have the gfortran toolchain installed) we need to override FLIBS to link to gfortran that is part of the R framework,

I don't really understand why the CRAN R build is not doing that by default...

@gaborcsardi mind raising that to Simon on r-macos-sig?

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this pull request.