Add codecov token in test coverage#823
Merged
gaborcsardi merged 4 commits intor-lib:v2-branchfrom Apr 11, 2024
Merged
Conversation
- To be able to upload the code coverage result to codecov.io users must now provide a CODECOV_TOKEN to authenticate to the service. - This token must be defined as a repository secret. - GITHUB_PAT is no longer required for the workflow to work
- Make the intent of the token explicit. - That way readers can clearly see that CODECOV_TOKEN in a requirement for `covr::codecov()`.
gaborcsardi
requested changes
Apr 11, 2024
Member
gaborcsardi
left a comment
There was a problem hiding this comment.
Thanks! Requested some changes.
…ter" This reverts commit 4f2a4d7.
Some packages need that to install dependencies from github for example
Member
|
Thanks! The thing is, if we want to keep the current behavior when the secret is not available, then we'll need to do a bit more work. :( It is not (easily) possible to conditionally set an env var in a GHA workflow, so we'll do this from the R code. I don't love this, but I think we need this to keep current repos working. In any case I can do that later, after this is merged. |
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #822
To be able to upload the code coverage result to codecov.io users must now provide a CODECOV_TOKEN to authenticate to the service. This token must be defined as a repository secret.
GITHUB_PAT is no longer required for the workflow to work
Explicitly pass CODECOV_TOKEN as covr::codecov() parameter to highlight its purpose