Fix resolving check-dir when changing working-directory#615
Merged
gaborcsardi merged 2 commits intor-lib:v2-branchfrom Oct 19, 2022
Merged
Conversation
* Should fix r-lib#614, at least for the typical case where `check-dir` is a relative path. * `check-dir` is now resolved relative to the working directory, as absolute path to also make it independent of the working directory of subsequent steps were the resolved `check-dir-path` output is used.
…feature/614-fix-check-dir-working-dir
Codecov Report
@@ Coverage Diff @@
## v2-branch #615 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 2 2
Lines 10 10
===========================================
Hits 10 10 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Member
|
Thanks much! |
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check-diris a relative path.check-diris now resolved relative to the working directory, as absolute path to also make it independent of the working directory of subsequent steps were the resolvedcheck-dir-pathoutput is used.See run https://github.com/riccardoporreca/actions/runs/8194198667?check_suite_focus=true#step:6:169 reproducing the issue:
See the same case fixed when using proposed fix from the branch in run https://github.com/riccardoporreca/actions/runs/8194292727?check_suite_focus=true#step:6:155