-
Notifications
You must be signed in to change notification settings - Fork 233
test-coverage action does not display testthat output on Windows #781
Description
Describe the bug
On windows, the test-coverage action does not display testthat output.
To Reproduce
see: https://github.com/esqLABS/esqlabsR/actions/runs/6970686406/job/18969127187#step:10:17
The action is looking for D:a_temp/package which does not exist since the step before ("Test coverage") stores the outputs at D:/a/_temp/package (from file.path(normalizePath(Sys.getenv("RUNNER_TEMP"), winslash = "/"), "package"))
Expected behavior
The action should look for the testthat.Rout file at D:/a/_temp/package.
Additional context
The problem seems to come from the interpretation of ${{ runner.temp }}/package in the "Show testthat output" step in a windows context since it results in D:a_temp/package instead of D:/a/_temp/package.
Possible fix
According to this, adding ' around the path constructor (like this: '${{ runner.temp }}/package' solves the issue. I tested it in our repository and it seems to work (see https://github.com/esqLABS/esqlabsR/actions/runs/6971498430/job/18971691010#step:10:1)
