Random Erase - Resolved copilot review comments#567
Merged
r-abishek merged 2 commits intor-abishek:ar/dropout_random_erasefrom Feb 25, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the random erase test-suite setup to use BitDepthTestMode constants (instead of magic bit-depth values) and to properly initialize per-image box counts before invoking rppt_random_erase.
Changes:
- Updated
init_dropout_erase()to branch onBitDepthTestModeenum values (e.g.,U8_TO_U8,F16_TO_F16, etc.) when filling the noise/color buffer. - Adjusted random-erase test invocations to pass
BitDepthTestModeand renamed the noise buffer variable tocolorBuffer. - Ensured
numOfBoxesis deterministically initialized/assigned (including changing per-image count assignment to= 1).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| utilities/test_suite/rpp_test_suite_image.h | Updates init_dropout_erase() to use BitDepthTestMode enums for buffer initialization and sets numOfBoxes[i] = 1. |
| utilities/test_suite/HOST/Tensor_image_host.cpp | Updates random-erase test setup to zero-init numBoxesTensor, rename noise buffer variable, and pass BitDepthTestMode. |
| utilities/test_suite/HIP/Tensor_image_hip.cpp | Initializes numOfBoxes for random erase and updates the init_dropout_erase() call to use batchSize and BitDepthTestMode. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
r-abishek
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.