Gaussian Filter ROI Fixes#543
Merged
r-abishek merged 3 commits intor-abishek:ar/opt_gaussian_filter_qa_f32from Dec 10, 2025
Merged
Gaussian Filter ROI Fixes#543r-abishek merged 3 commits intor-abishek:ar/opt_gaussian_filter_qa_f32from
r-abishek merged 3 commits intor-abishek:ar/opt_gaussian_filter_qa_f32from
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes critical bugs in the Gaussian filter ROI (Region of Interest) handling that previously assumed roiBegin was always zero. The changes ensure proper coordinate transformation from global to ROI-relative coordinates and correct padding boundary checks.
Key Changes:
- Transforms
clampedYandclampedXcalculations from global to ROI-relative coordinates - Removes incorrect
padLengthaddition from boundary condition checks - Updates boundary checks to use ROI-relative coordinates (comparing against 0 instead of
roiBeginX/roiBeginY)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
r-abishek
approved these changes
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated changes to handle any roiBegin - Current code assumes roiBegin is always zero
The condition for padding is also updated - Additional unwanted padLength addition was removed
Image before and after fix
