Warning fixes for HIP Backend#484
Merged
r-abishek merged 3 commits intor-abishek:ar/build_fix_hip_warningsfrom Sep 3, 2025
Merged
Warning fixes for HIP Backend#484r-abishek merged 3 commits intor-abishek:ar/build_fix_hip_warningsfrom
r-abishek merged 3 commits intor-abishek:ar/build_fix_hip_warningsfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds CHECK_RETURN_STATUS macro wrapping around HIP API calls to catch and handle errors in the HIP backend build. The changes ensure proper error checking for GPU memory operations and synchronization calls that were previously being invoked without status validation.
- Wraps hipMemset, hipMemcpy, hipStreamSynchronize, and similar HIP API calls with CHECK_RETURN_STATUS
- Adds error checking for device initialization and property queries
- Ensures memory operations and stream synchronization calls are properly validated
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/modules/tensor/rppt_tensor_effects_augmentations.cpp | Adds error checking for hipMemset and hipStreamSynchronize calls in gridmask and pixelate operations |
| src/modules/tensor/hip/kernel/to_decibels.cpp | Wraps hipStreamSynchronize calls with error checking |
| src/modules/tensor/hip/kernel/tensor_sum.cpp | Adds error checking for hipMemsetAsync and hipStreamSynchronize operations |
| src/modules/tensor/hip/kernel/tensor_stddev.cpp | Wraps hipMemsetAsync calls with error checking |
| src/modules/tensor/hip/kernel/tensor_min.cpp | Adds error checking for hipMemsetAsync and hipStreamSynchronize operations |
| src/modules/tensor/hip/kernel/tensor_mean.cpp | Wraps hipMemsetAsync calls with error checking |
| src/modules/tensor/hip/kernel/tensor_max.cpp | Adds error checking for hipMemsetAsync and hipStreamSynchronize operations |
| src/modules/tensor/hip/kernel/slice.cpp | Wraps hipStreamSynchronize call with error checking |
| src/modules/tensor/hip/kernel/resize_mirror_normalize.cpp | Adds error checking for hipMemsetAsync and hipStreamSynchronize calls |
| src/modules/tensor/hip/kernel/normalize.cpp | Wraps hipMemsetAsync and hipStreamSynchronize calls with error checking |
| src/modules/tensor/hip/kernel/noise_gaussian.cpp | Adds error checking for hipMemcpy call |
| src/modules/tensor/hip/kernel/erase.cpp | Wraps hipMemcpyAsync and hipStreamSynchronize calls with error checking |
| src/modules/tensor/hip/kernel/crop_and_patch.cpp | Adds error checking for hipMemcpyAsync and hipStreamSynchronize operations |
| src/modules/legacy_dep/hip/kernel/snow.cpp | Wraps hipMemcpy call with error checking |
| src/modules/handle_hip.cpp | Adds error checking for hipInit, hipEventElapsedTime, and hipGetDeviceProperties calls |
| src/include/common/rppi_validate.hpp | Wraps all hipMemcpy calls with error checking |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.