Test suite error detection enhancement#350
Merged
r-abishek merged 12 commits intor-abishek:ar/test_suite_mods_8from Nov 26, 2024
Merged
Test suite error detection enhancement#350r-abishek merged 12 commits intor-abishek:ar/test_suite_mods_8from
r-abishek merged 12 commits intor-abishek:ar/test_suite_mods_8from
Conversation
Dineshbabu-Ravichandran
commented
Oct 3, 2024
- Made changes to detect the errors in image HIP and HOST test suites and print them at the end
Collaborator
HazarathKumarM
left a comment
There was a problem hiding this comment.
@Dineshbabu-Ravichandran please resolve the comments
| stdout_data, stderr_data = result.communicate() | ||
| print(stdout_data.decode()) | ||
| exit_code = result.returncode | ||
| if(exit_code != 0): |
Collaborator
There was a problem hiding this comment.
please use camel case
utilities/test_suite/common.py
Outdated
| if (axisMaskCase): | ||
| result = result + "_" + str(nDim) + "d" + "_axisMask" + str(axisMask) | ||
| if (permOrderCase): | ||
| result =result + "_" + str(nDim) + "d" + "_permOrder" + str(permOrder) |
utilities/test_suite/common.py
Outdated
|
|
||
| def get_signal_name_from_return_code(return_code): | ||
| result = "" | ||
| if return_code < 0: |
Collaborator
There was a problem hiding this comment.
please use camel case for all variables
r-abishek
reviewed
Nov 20, 2024
| elif case == "26" and (("--input_path1" not in sys.argv and "--input_path2" not in sys.argv) or qaMode == 1): | ||
| srcPath1 = lensCorrectionInFilePath | ||
| srcPath2 = lensCorrectionInFilePath | ||
| else : |
Owner
There was a problem hiding this comment.
No space before colon. Same on L333
r-abishek
reviewed
Nov 20, 2024
| print(stdoutData.decode()) | ||
| exitCode = result.returncode | ||
| if(exitCode != 0): | ||
| log_detected_errors("Returned non-zero exit status : "+ str(exitCode) + " " + stderrData.decode(), errorLog, imageAugmentationMap[int(case)][0], get_bit_depth(int(bitDepth)), get_image_layout_type(layout, outputFormatToggle, "HOST"), get_signal_name_from_return_code(exitCode)) |
Owner
There was a problem hiding this comment.
L76-L80 is repeating almost 36 times in this PR with minor changes in arguments, can we consolidate to put it in one function in common.py, so all calls are single line calls?
r-abishek
requested changes
Nov 20, 2024
Owner
r-abishek
left a comment
There was a problem hiding this comment.
@Dineshbabu-Ravichandran Pls address comments
r-abishek
approved these changes
Nov 26, 2024
Owner
r-abishek
left a comment
There was a problem hiding this comment.
@Dineshbabu-Ravichandran @HazarathKumarM Hope all HIP/HOST tests are passing for this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.