Skip to content

Add album art to Android Auto#3534

Merged
ahmedre merged 1 commit intomainfrom
auto_album_art
Feb 22, 2026
Merged

Add album art to Android Auto#3534
ahmedre merged 1 commit intomainfrom
auto_album_art

Conversation

@ahmedre
Copy link
Copy Markdown
Contributor

@ahmedre ahmedre commented Feb 15, 2026

Refs #1086.

@ahmedre
Copy link
Copy Markdown
Contributor Author

ahmedre commented Feb 15, 2026

CleanShot 2026-02-16 at 03 40 30@2x CleanShot 2026-02-16 at 03 40 56@2x CleanShot 2026-02-16 at 03 41 04@2x CleanShot 2026-02-16 at 03 41 09@2x Screenshot_20260216_034659

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 16, 2026 

OLD: app-madani-debug.apk (signature: V1, V2)
NEW: app-madani-debug.apk (signature: V1, V2)

          │             compressed             │            uncompressed            
          ├───────────┬───────────┬────────────┼───────────┬───────────┬────────────
 APK      │ old       │ new       │ diff       │ old       │ new       │ diff       
──────────┼───────────┼───────────┼────────────┼───────────┼───────────┼────────────
      dex │  20.1 MiB │  20.1 MiB │   +4.6 KiB │  50.6 MiB │  50.6 MiB │  +11.2 KiB 
     arsc │   2.1 MiB │   2.1 MiB │        0 B │   2.1 MiB │   2.1 MiB │        0 B 
 manifest │   5.6 KiB │   5.6 KiB │        0 B │  26.2 KiB │  26.2 KiB │        0 B 
      res │   1.8 MiB │   1.8 MiB │       +4 B │     2 MiB │     2 MiB │        0 B 
   native │ 111.8 KiB │ 102.5 KiB │   -9.3 KiB │  36.5 KiB │  36.5 KiB │        0 B 
    asset │   1.6 MiB │   1.8 MiB │ +242.6 KiB │   3.8 MiB │   4.1 MiB │ +310.5 KiB 
    other │ 200.1 KiB │ 200.2 KiB │     +103 B │ 501.5 KiB │ 501.7 KiB │     +190 B 
──────────┼───────────┼───────────┼────────────┼───────────┼───────────┼────────────
    total │  25.9 MiB │  26.1 MiB │   +238 KiB │  59.1 MiB │  59.4 MiB │ +321.9 KiB

@ahmedre
Copy link
Copy Markdown
Contributor Author

ahmedre commented Feb 16, 2026

holding off until I replace this implementation with something more efficient - this works but is very expensive both in terms of cpu and memory (since we effectively block until we generate every image). have a partially working solution to that so will update before merging in sha' Allah.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 21, 2026 

OLD: app-madani-debug.apk (signature: V1, V2)
NEW: app-madani-debug.apk (signature: V1, V2)

          │             compressed             │            uncompressed            
          ├───────────┬───────────┬────────────┼───────────┬───────────┬────────────
 APK      │ old       │ new       │ diff       │ old       │ new       │ diff       
──────────┼───────────┼───────────┼────────────┼───────────┼───────────┼────────────
      dex │  20.1 MiB │  20.2 MiB │  +15.6 KiB │  50.6 MiB │  50.6 MiB │    +35 KiB 
     arsc │   2.1 MiB │   2.1 MiB │        0 B │   2.1 MiB │   2.1 MiB │        0 B 
 manifest │   5.6 KiB │   5.7 KiB │      +61 B │  26.2 KiB │  26.6 KiB │     +392 B 
      res │   1.8 MiB │   1.8 MiB │       +2 B │     2 MiB │     2 MiB │        0 B 
   native │ 111.8 KiB │ 112.7 KiB │     +872 B │  36.5 KiB │  36.5 KiB │        0 B 
    asset │   1.6 MiB │   1.8 MiB │ +242.6 KiB │   3.8 MiB │   4.1 MiB │ +310.5 KiB 
    other │ 200.1 KiB │ 200.2 KiB │      +86 B │ 501.5 KiB │ 501.7 KiB │     +190 B 
──────────┼───────────┼───────────┼────────────┼───────────┼───────────┼────────────
    total │  25.9 MiB │  26.2 MiB │ +259.1 KiB │  59.1 MiB │  59.4 MiB │ +346.1 KiB

@alti3
Copy link
Copy Markdown

alti3 commented Feb 22, 2026

holding off until I replace this implementation with something more efficient - this works but is very expensive both in terms of cpu and memory (since we effectively block until we generate every image). have a partially working solution to that so will update before merging in sha' Allah.

why not vectorize the images to SVGs.
114 SVGs, one for each surah
how large can it be?

@ahmedre
Copy link
Copy Markdown
Contributor Author

ahmedre commented Feb 22, 2026

That'd also work but the implementation here is good also after the updates so we can merge it

@ahmedre ahmedre added this pull request to the merge queue Feb 22, 2026
Merged via the queue into main with commit b6007d8 Feb 22, 2026
2 checks passed
@ahmedre ahmedre deleted the auto_album_art branch February 22, 2026 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ahmedre @alti3