Skip to content

Handle various line images not downloaded cases#3529

Merged
ahmedre merged 1 commit intomainfrom
fallback_no_lines
Feb 15, 2026
Merged

Handle various line images not downloaded cases#3529
ahmedre merged 1 commit intomainfrom
fallback_no_lines

Conversation

@ahmedre
Copy link
Copy Markdown
Contributor

@ahmedre ahmedre commented Feb 15, 2026

Today, if someone freshly installs and launches the app from a widget or
a shortcut, the app will insta-crash because the line by line images are
not available and the fallback did not kick in.

This PR fixes it by resetting to the default type of images (when
available) and restarting the activity. Unfortunately, this only helps
the main app and does not help the naskh app today (which does not have
a fallback set of images).

@ahmedre
Handle various line images not downloaded cases
05a2fe8 
Today, if someone freshly installs and launches the app from a widget or
a shortcut, the app will insta-crash because the line by line images are
not available and the fallback did not kick in.

This PR fixes it by resetting to the default type of images (when
available) and restarting the activity. Unfortunately, this only helps
the main app and does not help the naskh app today (which does not have
a fallback set of images).
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 15, 2026 

OLD: app-madani-debug.apk (signature: V1, V2)
NEW: app-madani-debug.apk (signature: V1, V2)

          │           compressed           │          uncompressed          
          ├───────────┬───────────┬────────┼───────────┬───────────┬────────
 APK      │ old       │ new       │ diff   │ old       │ new       │ diff   
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼────────
      dex │  20.1 MiB │  20.1 MiB │ +123 B │  50.6 MiB │  50.6 MiB │ +296 B 
     arsc │   2.1 MiB │   2.1 MiB │    0 B │   2.1 MiB │   2.1 MiB │    0 B 
 manifest │   5.6 KiB │   5.6 KiB │    0 B │  26.2 KiB │  26.2 KiB │    0 B 
      res │   1.8 MiB │   1.8 MiB │    0 B │     2 MiB │     2 MiB │    0 B 
   native │  81.3 KiB │  81.1 KiB │ -246 B │  36.5 KiB │  36.5 KiB │    0 B 
    asset │   1.6 MiB │   1.6 MiB │    0 B │   3.8 MiB │   3.8 MiB │    0 B 
    other │ 200.1 KiB │ 200.1 KiB │   -1 B │ 501.5 KiB │ 501.5 KiB │    0 B 
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼────────
    total │  25.9 MiB │  25.9 MiB │ -124 B │  59.1 MiB │  59.1 MiB │ +296 B

@ahmedre ahmedre added this pull request to the merge queue Feb 15, 2026
Merged via the queue into main with commit 06f3082 Feb 15, 2026
2 checks passed
@ahmedre ahmedre deleted the fallback_no_lines branch February 15, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ahmedre