Skip to content

Fix Compose previews for single variant aars#3393

Merged
ahmedre merged 1 commit intomainfrom
compose_previews
Oct 13, 2025
Merged

Fix Compose previews for single variant aars#3393
ahmedre merged 1 commit intomainfrom
compose_previews

Conversation

@ahmedre
Copy link
Copy Markdown
Contributor

@ahmedre ahmedre commented Oct 13, 2025

The Android library modules are all single variant (since the debug
variant is intentionally disabled). This causes issues with Compose
previews, since the tooling is only available for debug builds. This
patch changes these to vanilla implementation, and removes them from
release builds instead.

@ahmedre
Fix Compose previews for single variant aars
25c547b 
The Android library modules are all single variant (since the debug
variant is intentionally disabled). This causes issues with Compose
previews, since the tooling is only available for debug builds. This
patch changes these to vanilla implementation, and removes them from
release builds instead.
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 13, 2025 

OLD: app-madani-debug.apk (signature: V1, V2)
NEW: app-madani-debug.apk (signature: V1, V2)

          │             compressed             │            uncompressed            
          ├───────────┬───────────┬────────────┼───────────┬───────────┬────────────
 APK      │ old       │ new       │ diff       │ old       │ new       │ diff       
──────────┼───────────┼───────────┼────────────┼───────────┼───────────┼────────────
      dex │  19.6 MiB │  19.7 MiB │  +99.7 KiB │  49.1 MiB │  49.4 MiB │ +257.9 KiB 
     arsc │   2.1 MiB │   2.1 MiB │        0 B │   2.1 MiB │   2.1 MiB │        0 B 
 manifest │   6.1 KiB │   6.1 KiB │      +50 B │  29.7 KiB │  29.9 KiB │     +192 B 
      res │   1.8 MiB │   1.8 MiB │        0 B │     2 MiB │     2 MiB │        0 B 
   native │  18.8 KiB │  18.8 KiB │        0 B │  36.5 KiB │  36.5 KiB │        0 B 
    asset │ 452.1 KiB │ 452.1 KiB │        0 B │ 808.2 KiB │ 808.2 KiB │        0 B 
    other │ 197.6 KiB │ 198.1 KiB │     +460 B │ 494.5 KiB │   495 KiB │     +498 B 
──────────┼───────────┼───────────┼────────────┼───────────┼───────────┼────────────
    total │  24.1 MiB │  24.2 MiB │ +100.2 KiB │  54.6 MiB │  54.9 MiB │ +258.6 KiB

@ahmedre ahmedre added this pull request to the merge queue Oct 13, 2025
Merged via the queue into main with commit 6565c03 Oct 13, 2025
2 checks passed
@ahmedre ahmedre deleted the compose_previews branch October 13, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ahmedre