Skip to content

Fix silent crash for audio updates#3369

Merged
ahmedre merged 1 commit intomainfrom
fix_audio_worker
Sep 21, 2025
Merged

Fix silent crash for audio updates#3369
ahmedre merged 1 commit intomainfrom
fix_audio_worker

Conversation

@ahmedre
Copy link
Copy Markdown
Contributor

@ahmedre ahmedre commented Sep 21, 2025

The audio update worker returns 204 when there are no new audio updates.
Return a Response wrapper instead to be able to better handle this case.

The audio update worker returns 204 when there are no new audio updates.
Return a Response wrapper instead to be able to better handle this case.
@ahmedre ahmedre enabled auto-merge September 21, 2025 16:24
@ahmedre ahmedre added this pull request to the merge queue Sep 21, 2025
@github-actions
Copy link
Copy Markdown

OLD: app-madani-debug.apk (signature: V1, V2)
NEW: app-madani-debug.apk (signature: V1, V2)

          │          compressed           │          uncompressed          
          ├───────────┬───────────┬───────┼───────────┬───────────┬────────
 APK      │ old       │ new       │ diff  │ old       │ new       │ diff   
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼────────
      dex │  25.6 MiB │  25.6 MiB │ +42 B │  78.2 MiB │  78.2 MiB │ +228 B 
     arsc │   2.1 MiB │   2.1 MiB │   0 B │   2.1 MiB │   2.1 MiB │    0 B 
 manifest │   6.1 KiB │   6.1 KiB │   0 B │  29.7 KiB │  29.7 KiB │    0 B 
      res │   1.8 MiB │   1.8 MiB │  +4 B │     2 MiB │     2 MiB │    0 B 
   native │  18.8 KiB │  18.8 KiB │   0 B │  36.5 KiB │  36.5 KiB │    0 B 
    asset │ 452.1 KiB │ 452.1 KiB │   0 B │ 808.2 KiB │ 808.2 KiB │    0 B 
    other │ 198.3 KiB │ 198.3 KiB │  +5 B │ 495.1 KiB │ 495.1 KiB │    0 B 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼────────
    total │  30.1 MiB │  30.1 MiB │ +51 B │  83.6 MiB │  83.6 MiB │ +228 B 

Merged via the queue into main with commit da30531 Sep 21, 2025
2 checks passed
@ahmedre ahmedre deleted the fix_audio_worker branch September 21, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant