Fix missing basmallah for gapless playback#3365
Merged
Conversation
When playing from a gapless sura, the MediaPlayer code used to start at the timestamp for ayah=0 (usually the basmallah for suras that aren't Fatiha nor Tawba), falling back to ayah=1 otherwise. During the migration to ExoPlayer, this was inadvertently changed to always start at ayah=1, preventing the basmallah from playing.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When playing from a gapless sura, the MediaPlayer code used to start at
the timestamp for ayah=0 (usually the basmallah for suras that aren't
Fatiha nor Tawba), falling back to ayah=1 otherwise. During the
migration to ExoPlayer, this was inadvertently changed to always start
at ayah=1, preventing the basmallah from playing.