Skip to content

Do not wait for all DNS resolvers to return#3350

Merged
ahmedre merged 1 commit intomainfrom
fix_multi_dns
Sep 13, 2025
Merged

Do not wait for all DNS resolvers to return#3350
ahmedre merged 1 commit intomainfrom
fix_multi_dns

Conversation

@ahmedre
Copy link
Copy Markdown
Contributor

@ahmedre ahmedre commented Sep 13, 2025

Previously, due to the coroutine scope, MultiDns was forced to await all
dns providers to finish before returning. Since the lookups are blocking
calls and do not respect cancellation, this could take some time. This
patch fixes it so they're in a separate coroutine scope, so that we
don't have to wait on the cancellation before returning.

@ahmedre
Do not wait for all DNS resolvers to return
1081ab7 
Previously, due to the coroutine scope, MultiDns was forced to await all
dns providers to finish before returning. Since the lookups are blocking
calls and do not respect cancellation, this could take some time. This
patch fixes it so they're in a separate coroutine scope, so that we
don't have to wait on the cancellation before returning.
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 13, 2025 

OLD: app-madani-debug.apk (signature: V1, V2)
NEW: app-madani-debug.apk (signature: V1, V2)

          │           compressed           │         uncompressed          
          ├───────────┬───────────┬────────┼───────────┬───────────┬───────
 APK      │ old       │ new       │ diff   │ old       │ new       │ diff  
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼───────
      dex │  25.6 MiB │  25.6 MiB │ +129 B │  78.2 MiB │  78.2 MiB │ +52 B 
     arsc │   2.1 MiB │   2.1 MiB │    0 B │   2.1 MiB │   2.1 MiB │   0 B 
 manifest │   6.1 KiB │   6.1 KiB │    0 B │  29.9 KiB │  29.9 KiB │   0 B 
      res │   1.8 MiB │   1.8 MiB │   +6 B │     2 MiB │     2 MiB │   0 B 
   native │  18.8 KiB │  18.8 KiB │    0 B │  36.5 KiB │  36.5 KiB │   0 B 
    asset │ 452.1 KiB │ 452.1 KiB │    0 B │ 808.2 KiB │ 808.2 KiB │   0 B 
    other │ 198.3 KiB │ 198.3 KiB │   +2 B │ 495.1 KiB │ 495.1 KiB │   0 B 
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼───────
    total │  30.1 MiB │  30.1 MiB │ +137 B │  83.6 MiB │  83.6 MiB │ +52 B

@ahmedre ahmedre added this pull request to the merge queue Sep 13, 2025
Merged via the queue into main with commit 5407d3d Sep 13, 2025
2 checks passed
@ahmedre ahmedre deleted the fix_multi_dns branch September 13, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ahmedre