Skip to content

Improve dns lookups#3328

Merged
ahmedre merged 1 commit intomainfrom
improve_dns
Aug 31, 2025
Merged

Improve dns lookups#3328
ahmedre merged 1 commit intomainfrom
improve_dns

Conversation

@ahmedre
Copy link
Copy Markdown
Contributor

@ahmedre ahmedre commented Aug 31, 2025

This patch does a few things:

  • re-adds Dns.SYSTEM - this wasn't actually a default in DnsFallback
  • removes the advanced setting for DnsOverHttps
  • instead of iterating through all the dns servers sequentially and
    using the first response, query all providers in parallel and return
    the first result.

Fixes #3235.

@ahmedre
Improve dns lookups
d9a9f92 
This patch does a few things:
- re-adds Dns.SYSTEM - this wasn't actually a default in DnsFallback
- removes the advanced setting for DnsOverHttps
- instead of iterating through all the dns servers sequentially and
  using the first response, query all providers in parallel and return
  the first result.

Fixes #3235.
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 31, 2025 

OLD: app-madani-debug.apk (signature: V1, V2)
NEW: app-madani-debug.apk (signature: V1, V2)

          │            compressed            │           uncompressed           
          ├───────────┬───────────┬──────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff     │ old       │ new       │ diff     
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
      dex │  25.3 MiB │  25.3 MiB │ +2.9 KiB │  77.6 MiB │  77.6 MiB │ +6.6 KiB 
     arsc │     2 MiB │     2 MiB │ -1.1 KiB │     2 MiB │     2 MiB │ -1.1 KiB 
 manifest │   6.1 KiB │   6.1 KiB │      0 B │  29.9 KiB │  29.9 KiB │      0 B 
      res │   1.8 MiB │   1.8 MiB │    -82 B │     2 MiB │     2 MiB │   -268 B 
   native │  18.8 KiB │  18.8 KiB │      0 B │  36.5 KiB │  36.5 KiB │      0 B 
    asset │ 452.1 KiB │ 452.1 KiB │      0 B │ 808.2 KiB │ 808.2 KiB │      0 B 
    other │ 195.1 KiB │ 195.1 KiB │     -7 B │ 486.1 KiB │ 486.1 KiB │      0 B 
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
    total │  29.7 MiB │  29.7 MiB │ +1.7 KiB │  82.9 MiB │  82.9 MiB │ +5.2 KiB

@ahmedre ahmedre added this pull request to the merge queue Aug 31, 2025
Merged via the queue into main with commit 12f6ede Aug 31, 2025
2 checks passed
@ahmedre ahmedre deleted the improve_dns branch August 31, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve custom DNS situation

1 participant

@ahmedre