Skip to content

Fix gapped qaris not playing#3314

Merged
ahmedre merged 1 commit intomainfrom
fix_gapped_audio
Aug 24, 2025
Merged

Fix gapped qaris not playing#3314
ahmedre merged 1 commit intomainfrom
fix_gapped_audio

Conversation

@ahmedre
Copy link
Copy Markdown
Contributor

@ahmedre ahmedre commented Aug 24, 2025

Fixes #3297.

@github-actions
Copy link
Copy Markdown

OLD: app-madani-debug.apk (signature: V1, V2)
NEW: app-madani-debug.apk (signature: V1, V2)

          │          compressed           │         uncompressed          
          ├───────────┬───────────┬───────┼───────────┬───────────┬───────
 APK      │ old       │ new       │ diff  │ old       │ new       │ diff  
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼───────
      dex │  25.4 MiB │  25.4 MiB │ +58 B │  77.7 MiB │  77.7 MiB │ +64 B 
     arsc │     2 MiB │     2 MiB │   0 B │     2 MiB │     2 MiB │   0 B 
 manifest │   6.1 KiB │   6.1 KiB │   0 B │  29.9 KiB │  29.9 KiB │   0 B 
      res │   1.8 MiB │   1.8 MiB │  +4 B │     2 MiB │     2 MiB │   0 B 
   native │  18.8 KiB │  18.8 KiB │   0 B │  36.5 KiB │  36.5 KiB │   0 B 
    asset │ 452.1 KiB │ 452.1 KiB │   0 B │ 808.2 KiB │ 808.2 KiB │   0 B 
    other │ 195.1 KiB │ 195.1 KiB │  +8 B │ 486.1 KiB │ 486.1 KiB │   0 B 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼───────
    total │  29.8 MiB │  29.8 MiB │ +70 B │    83 MiB │    83 MiB │ +64 B 

@ahmedre
Copy link
Copy Markdown
Contributor Author

ahmedre commented Aug 24, 2025

note that there's a ui bug where loading stays on the audio bar without switching away when switching between files (both in gapped and gapless). since that bug is related to the ExoPlayer migration and affects both gapped and gapless, will fix it in a separate PR in sha' Allah.

@ahmedre ahmedre added this pull request to the merge queue Aug 24, 2025
Merged via the queue into main with commit ff3eb4a Aug 24, 2025
2 checks passed
@ahmedre ahmedre deleted the fix_gapped_audio branch August 24, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gapped qari no download no play

1 participant