Skip to content

Add support for opus files#3189

Merged
ahmedre merged 1 commit intomainfrom
support_opus
May 25, 2025
Merged

Add support for opus files#3189
ahmedre merged 1 commit intomainfrom
support_opus

Conversation

@ahmedre
Copy link
Copy Markdown
Contributor

@ahmedre ahmedre commented May 24, 2025

This adds support for different audio formats and places the logic to
decide which format to use behind an interface so that it can be tweaked
later if necessary.

For now, all new qaris will default to opus only. Based on this, can
decide what to do on existing qaris that get opus support in the future
in sha' Allah.

@ahmedre
Add support for opus files
9329094 
This adds support for different audio formats and places the logic to
decide which format to use behind an interface so that it can be tweaked
later if necessary.

For now, all new qaris will default to opus only. Based on this, can
decide what to do on existing qaris that get opus support in the future
in sha' Allah.
@github-actions
Copy link
Copy Markdown

github-actions bot commented May 25, 2025 

OLD: app-madani-debug.apk (signature: V1, V2)
NEW: app-madani-debug.apk (signature: V1, V2)

          │            compressed            │           uncompressed            
          ├───────────┬───────────┬──────────┼───────────┬───────────┬───────────
 APK      │ old       │ new       │ diff     │ old       │ new       │ diff      
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼───────────
      dex │  24.8 MiB │  24.8 MiB │ +6.4 KiB │  76.2 MiB │  76.2 MiB │ +14.5 KiB 
     arsc │   2.7 MiB │   2.7 MiB │      0 B │   2.7 MiB │   2.7 MiB │       0 B 
 manifest │   5.8 KiB │   5.8 KiB │      0 B │  28.3 KiB │  28.3 KiB │       0 B 
      res │   1.8 MiB │   1.8 MiB │     +2 B │     2 MiB │     2 MiB │       0 B 
   native │  18.8 KiB │  18.8 KiB │      0 B │  36.5 KiB │  36.5 KiB │       0 B 
    asset │ 404.2 KiB │ 404.2 KiB │      0 B │ 678.6 KiB │ 678.6 KiB │       0 B 
    other │ 227.3 KiB │ 227.3 KiB │    -19 B │ 488.1 KiB │ 488.1 KiB │       0 B 
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼───────────
    total │  29.9 MiB │  29.9 MiB │ +6.4 KiB │  82.1 MiB │  82.1 MiB │ +14.5 KiB

@ahmedre ahmedre added this pull request to the merge queue May 25, 2025
Merged via the queue into main with commit 52e8f5d May 25, 2025
2 checks passed
@ahmedre ahmedre deleted the support_opus branch May 25, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ahmedre