Skip to content

Fix: Ensure bookmarked ayahs respect translation mode (#3130)#3131

Merged
ahmedre merged 1 commit intoquran:mainfrom
sapakus:fix-bookmark-translation-mode
Apr 5, 2025
Merged

Fix: Ensure bookmarked ayahs respect translation mode (#3130)#3131
ahmedre merged 1 commit intoquran:mainfrom
sapakus:fix-bookmark-translation-mode

Conversation

@sapakus
Copy link
Copy Markdown
Contributor

@sapakus sapakus commented Apr 4, 2025

Fix: Ensure bookmarked ayahs respect translation mode

Description

This PR fixes an inconsistency where bookmarked ayahs always open in Quran mode, regardless of whether the user was in translation mode. The EXTRA_JUMP_TO_TRANSLATION flag is now passed in the jumpToAndHighlight method to ensure the correct mode is respected.

Related Issue

Fixes #3130

Changes Made

  • Updated jumpToAndHighlight in QuranActivity to include the EXTRA_JUMP_TO_TRANSLATION flag.

Testing

  • Verified that bookmarked pages and ayahs now respect the current mode (translation or Quran mode).

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 5, 2025 

OLD: app-madani-debug.apk (signature: V1, V2)
NEW: app-madani-debug.apk (signature: V1, V2)

          │          compressed           │         uncompressed          
          ├───────────┬───────────┬───────┼───────────┬───────────┬───────
 APK      │ old       │ new       │ diff  │ old       │ new       │ diff  
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼───────
      dex │  24.1 MiB │  24.1 MiB │ +51 B │  74.6 MiB │  74.6 MiB │ +24 B 
     arsc │   2.7 MiB │   2.7 MiB │   0 B │   2.7 MiB │   2.7 MiB │   0 B 
 manifest │   5.8 KiB │   5.8 KiB │   0 B │    28 KiB │    28 KiB │   0 B 
      res │   1.7 MiB │   1.7 MiB │  -6 B │     2 MiB │     2 MiB │   0 B 
   native │  18.8 KiB │  18.8 KiB │   0 B │  36.5 KiB │  36.5 KiB │   0 B 
    asset │ 404.2 KiB │ 404.2 KiB │   0 B │ 678.6 KiB │ 678.6 KiB │   0 B 
    other │ 219.9 KiB │ 219.9 KiB │  -1 B │ 467.5 KiB │ 467.5 KiB │   0 B 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼───────
    total │  29.2 MiB │  29.2 MiB │ +44 B │  80.4 MiB │  80.4 MiB │ +24 B

@ahmedre
Copy link
Copy Markdown
Contributor

ahmedre commented Apr 5, 2025

jazakumAllah khairan

@ahmedre ahmedre added this pull request to the merge queue Apr 5, 2025
Merged via the queue into quran:main with commit 970a49e Apr 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug Report: Bookmark Navigation Inconsistency with Translation Mode

2 participants

@sapakus @ahmedre