HTML Reporter: Make it more obvious why diff is suppressed#795
HTML Reporter: Make it more obvious why diff is suppressed#795shivamdixit wants to merge 9 commits into
Conversation
|
Ideally it says what the current max depth is and provides a link to rerun with a higher max depth or no max depth. |
|
@scottgonzalez I've updated the PR. Screenshot:
@jzaefferer Please provide your valuable suggestions as well. |
|
I think the tests are failing because of the timeout. How can I re-run the tests? |
There was a problem hiding this comment.
This should use setUrl() to generate QUnit specific URLs that include other URL parameters already present (filters etc.).
|
@shivamdixit thanks for the PR. I have very little bandwidth to review anything this week. I added one comment above. I'd like to discuss the general concept for tackling this issue, but that has to wait a few days. |
|
That screenshot looks great. You should wrap Fixing the styling of the rerun link should be very simple, but let's wait for the team to discuss. |
|
@jzaefferer @scottgonzalez Thanks for your suggestions. I've updated the code. |
|
Let's add some CSS to display the Rerun link properly, just change |
|
LGTM |


If the depth of an object is more than 'Max Depth' specified in
Qunit.dumpthen the diff is not displayed. This behavior is confusing. This PR will display a message to the user so that user knows why it is not displayed.Refer: #793 (comment)
I'm confused with what text to display to the user since the user might not be aware of max depth. Any suggestions?
Screenshot:
