HTML Reporter: Fixed the confusing Line Breaks in Diffs#764
HTML Reporter: Fixed the confusing Line Breaks in Diffs#764gauravmittal1995 wants to merge 1 commit into
Conversation
|
@leobalter @jzaefferer Please Review |
|
Can you provide a screenshot of those same diffs without the changes of this PR applied? |
|
Also #348 had an example where an object was replaced by an array. Could you cover that as well? |
|
@jzaefferer for the object replaced by array: |
|
@jzaefferer Hey, I also tried another way and got the following diff: Please Let me know which one according to you is better. |
|
Both approaches are definitely an improvement over the current implementation. The "another way" looks even better to me. We may need more tests to avoid regressions though. @leobalter what do you think? |
|
@jzaefferer the another way uses google's diff-patch-match library. |
|
Ah, good to know. Could you create a separate PR for that? |
|
I liked these changes, but I would like to see this other PR as it looks better. |
|
@jzaefferer @leobalter Creating the new PR. Its taking time because have to refactor as it doesnt use cameCase and vars are scattered throughout the function. Will send it soon |
|
As it is an external library, it would be good to ignore it on jshint and jscs checks. Also, getting the code from a npm dependency would be nice. |
|
@leobalter @jzaefferer PR opened #772 |
|
@jzaefferer I think its safe to close this PR as we r mostly gonna stick with #772 ?? |
|
Yes, @gauravmittal1995, thanks! |





Regarding #348
In the Below picture:
1st assert has same keys but different values,
2nd assert is for two strings,
3rd assert has different keys but similar values.