Skip to content

CLI: Add --seed=true to generate a new seed#1800

Merged
Krinkle merged 1 commit intoqunitjs:mainfrom
Krinkle:seed-new
Sep 29, 2024
Merged

CLI: Add --seed=true to generate a new seed#1800
Krinkle merged 1 commit intoqunitjs:mainfrom
Krinkle:seed-new

Conversation

@Krinkle
Copy link
Copy Markdown
Member

@Krinkle Krinkle commented Sep 16, 2024

  • Change --seed to require a value.
    This fixes the conflict with test file arguments, raised in CLI --seed without value and files argument is counterintuitive #1691.
  • Add --seed=true to generate a new seed.
    This makes it consistent with URL Params, where ?seed (which translated to seed=true) already did this. With this patch, we now also support pre-config qunit_config_seed=true and qunit_config_seed="true". As well as --seed=true on the CLI. And URL param ?seed=true (in case someone tries/expects that).

While at it, this also:

  • Remove duplicate logic from CLI for generating new seed value in value of /src/core/config.js, by translating --seed to a preconfig.

Fixes #1691.

@Krinkle Krinkle added this to the 3.0 release milestone Sep 16, 2024
@Krinkle Krinkle merged commit a0027db into qunitjs:main Sep 29, 2024
@Krinkle Krinkle deleted the seed-new branch September 29, 2024 16:54
@Krinkle Krinkle modified the milestones: 3.0 release, 2.x release Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

CLI --seed without value and files argument is counterintuitive

1 participant