Skip to content

Test: Add more tests for test context in module scope and inheritence#1770

Merged
Krinkle merged 1 commit intomainfrom
more-context-tests
Jun 23, 2024
Merged

Test: Add more tests for test context in module scope and inheritence#1770
Krinkle merged 1 commit intomainfrom
more-context-tests

Conversation

@Krinkle
Copy link
Copy Markdown
Member

@Krinkle Krinkle commented Jun 23, 2024

Use separate properties to be able to distinguish between own and inherited ones. When "appending" to a property, it effectively copies it do the own object, making it hard to notice whether the properties of a parent module really are copied/preserved at each step, vs only visible at step 1 where it copies it thus masking later bugs where we might forget to extend/mixin the parent env.

Also add a test for the module scope callback's context object.

Ref #1762.

Use separate properties to be able to distinguish between own and
inherited ones. When "appending" to a property, it effectively copies
it do the own object, making it hard to notice whether the properties
of a parent module really are copied/preserved at each step, vs only
visible at step 1 where it copies it thus masking later bugs where
we might forget to extend/mixin the parent env.

Also add a test for the module scope callback's context object.

Ref #1762.
@Krinkle Krinkle requested a review from raycohen June 23, 2024 23:45
@Krinkle Krinkle merged commit cb505fe into main Jun 23, 2024
@Krinkle Krinkle deleted the more-context-tests branch June 23, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant