Test: Add more tests for test context in module scope and inheritence#1770
Merged
Test: Add more tests for test context in module scope and inheritence#1770
Conversation
Use separate properties to be able to distinguish between own and inherited ones. When "appending" to a property, it effectively copies it do the own object, making it hard to notice whether the properties of a parent module really are copied/preserved at each step, vs only visible at step 1 where it copies it thus masking later bugs where we might forget to extend/mixin the parent env. Also add a test for the module scope callback's context object. Ref #1762.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use separate properties to be able to distinguish between own and inherited ones. When "appending" to a property, it effectively copies it do the own object, making it hard to notice whether the properties of a parent module really are copied/preserved at each step, vs only visible at step 1 where it copies it thus masking later bugs where we might forget to extend/mixin the parent env.
Also add a test for the module scope callback's context object.
Ref #1762.