Skip to content

Support objects as input to test.each#1614

Merged
Krinkle merged 8 commits intoqunitjs:mainfrom
ventuno:ftr-1569
Jun 5, 2021
Merged

Support objects as input to test.each#1614
Krinkle merged 8 commits intoqunitjs:mainfrom
ventuno:ftr-1569

Conversation

@ventuno
Copy link
Copy Markdown
Member

@ventuno ventuno commented May 16, 2021

Follow up on #1568 (comment) to add support for objects as input to test.each.

Screen Shot 2021-05-16 at 7 09 04 PM

@Krinkle, @smcclure15 let me know what your thoughts are on this change.

@ventuno ventuno requested review from Krinkle and smcclure15 May 16, 2021 23:19
@ventuno ventuno mentioned this pull request May 16, 2021
Copy link
Copy Markdown
Member

@Krinkle Krinkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍. I've fiddled with the docs in b3521d0, so I'm afriad this needs a rebase (perhaps make the "object as data" case its own example?), but otherwise good to go!

@ventuno ventuno requested a review from Krinkle May 23, 2021 20:16
@ventuno
Copy link
Copy Markdown
Member Author

ventuno commented May 23, 2021

@Krinkle, thanks do you mind taking another look?

@Krinkle Krinkle merged commit e6d513b into qunitjs:main Jun 5, 2021
@ventuno ventuno deleted the ftr-1569 branch June 5, 2021 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants