Skip to content

qunit does not run all tests in a module #1322

@shlomif

Description

@shlomif

Tell us about your runtime:

  • QUnit version: 2.7.0
  • What environment are you running QUnit in? (e.g., browser, Node): browser, tested on firefox nightly/stable and chromium
  • How are you running QUnit? (e.g., script, testem, Grunt): script/require.js

What are you trying to do?

Code that reproduces the problem:

See https://www.shlomifish.org/fc-solve--qunit-1/js-fc-solve/automated-tests/i.html - source is here - https://github.com/shlomif/fc-solve/tree/qunit-bug--module-hooks/fc-solve/site/wml (note the branch).

If you have any relevant configuration information, please include that here:

What did you expect to happen?

Run all tests.

What actually happened?

not all tests were run and I get something in the console.

If I comment out this line:

  		function logSuiteEnd(module) {

  			// Reset `module.hooks` to ensure that anything referenced in these hooks
  			// has been released to be garbage collected.
  			module.hooks = {}; // <- THIS ONE

  			emit("suiteEnd", module.suiteReport.end(true));
  			runLoggingCallbacks("moduleDone", {
  				name: module.name,
  				tests: module.tests,
  				failed: module.stats.bad,
  				passed: module.stats.all - module.stats.bad,
  				total: module.stats.all,
  				runtime: now() - module.stats.started
  			});
  		}

then the problem disappears.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions