Conversation
Member
Skn0tt
commented
Oct 18, 2022
- fix: update some fastify packages
- dont use deprecated method
- update even more
✅ Deploy Preview for quirrel-docs canceled.
|
✅ Deploy Preview for quirrel-development-ui ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Comment on lines
+34
to
+49
| async (connection, req) => { | ||
| workAroundWebsocketAuth(req); | ||
|
|
||
| const tokenId = await fastify.tokenAuth.authenticate(req); | ||
| const tokenId = await fastify.tokenAuth.authenticate(req); | ||
|
|
||
| if (!tokenId) { | ||
| connection.socket.close(); | ||
| return; | ||
| } | ||
| if (!tokenId) { | ||
| connection.socket.close(); | ||
| return; | ||
| } | ||
|
|
||
| const close = fastify.jobs.onEvent(tokenId, (event, job) => { | ||
| connection.socket.send(JSON.stringify([event, job])); | ||
| }); | ||
| const close = fastify.jobs.onEvent(tokenId, (event, job) => { | ||
| connection.socket.send(JSON.stringify([event, job])); | ||
| }); | ||
|
|
||
| connection.on("close", close); | ||
| } | ||
| ); | ||
| connection.on("close", close); | ||
| } |
Check failure
Code scanning / CodeQL
Missing rate limiting
Contributor
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
Skn0tt
added a commit
that referenced
this pull request
Oct 21, 2022
🤖 I have created a release *beep* *boop* --- ## [1.11.0](v1.10.0...v1.11.0) (2022-10-21) ### Features * support node v18 ([#1047](#1047)) ([2d520e0](2d520e0)) * support node v18 ([#1057](#1057)) ([a306f8e](a306f8e)) ### Bug Fixes * **deps:** update dependency conditional-type-checks to v1.0.6 ([#1060](#1060)) ([7084e8d](7084e8d)) * **deps:** update dependency fastify-plugin to v4 ([#1070](#1070)) ([913f202](913f202)) * update fastify + others ([#1055](#1055)) ([7404f84](7404f84)) * update some deps ([#1046](#1046)) ([6f3a8b7](6f3a8b7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.